From patchwork Mon Jan 12 08:13:59 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: 2.6.28-git8: tg3 doesn't work due to firmware not loading (-git7 is ok) From: David Woodhouse X-Patchwork-Id: 17887 Message-Id: <1231748039.25018.1277.camel@macbook.infradead.org> To: Valdis.Kletnieks@vt.edu Cc: David Miller , alessandro.suardi@gmail.com, jaswinderlinux@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Date: Mon, 12 Jan 2009 08:13:59 +0000 On Sun, 2009-01-11 at 19:10 -0500, Valdis.Kletnieks@vt.edu wrote: > So it looks like the patch is failing to finish initialization of the card. > Damned if *I* can see what's breaking it, the conversion to use a helper > function tg3_request_firmware seems sane enough.... Ahem... --- drivers/net/tg3.c.stupiddwmw2 2009-01-12 08:13:05.000000000 +0000 +++ drivers/net/tg3.c 2009-01-12 08:13:09.000000000 +0000 @@ -13151,7 +13151,7 @@ static int __devinit tg3_init_one(struct try again in tg3_open(). So if you have the driver built into the kernel, you can still get the firmware loaded after userspace is running, when the device comes up. */ - if (err != -ENOENT) + if (err && err != -ENOENT) goto err_out_fw; }