From patchwork Mon Aug 20 14:13:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Richard Earnshaw X-Patchwork-Id: 178823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0E4392C00A2 for ; Tue, 21 Aug 2012 00:15:39 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1346076940; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Mailing-List:Precedence: List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=SWxdJeoD5OsoMYx4xea9dQLpX0g=; b=xZoBmZh4qzTPuwc lYrQJirBFg8n9v6KIPbKIVTrP28J6FMXddU//MvIjuhcmP8NRlTv4TqTekAV5Sgg lGLdJFWGDzOL53nYo/HlIFSwIqaVTZn34VISMt9TxmN0IjxylBE7zF9QSY0Vpk02 u6CuysF/u3oSkHjr4WkqNX3x96Zc= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:X-MC-Unique:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=BIqI//GdeNhxS9boXTW+isVbhHvagw6UBjop8cErtuA6vKS9a++yCuSwzUAFP/ 9xKG6+o5KlZqa2bVFdr+N/G0Ny3W8vJtebtg8ODa7pI+e2ExwykN3BaTjvNXsh+E 8RP3zwpVzgqdLxvsu7AB0DKj6M7g3EBrwF2L8AARzB2L0=; Received: (qmail 21483 invoked by alias); 20 Aug 2012 14:14:22 -0000 Received: (qmail 21408 invoked by uid 22791); 20 Aug 2012 14:14:17 -0000 X-SWARE-Spam-Status: No, hits=-1.5 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_DNSWL_LOW, TW_TM X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (91.220.42.44) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Aug 2012 14:13:58 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Mon, 20 Aug 2012 15:13:56 +0100 Received: from [10.1.69.67] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 20 Aug 2012 15:15:44 +0100 Message-ID: <50324622.3020900@arm.com> Date: Mon, 20 Aug 2012 15:13:54 +0100 From: Richard Earnshaw User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Tobias Burnus CC: Andrew Stubbs , "gcc-patches@gcc.gnu.org" , Richard Sandiford Subject: Re: [patch, tree-ssa] PR54295 Incorrect value extension in widening multiply-accumulate References: <502E4F54.9040309@arm.com> <502E53A7.406@codesourcery.com> <502E55CE.6020304@arm.com> <502E57A9.8050502@codesourcery.com> <502E598F.9010105@arm.com> <502E5DE6.8090806@codesourcery.com> <502E612E.60706@arm.com> <502E79BC.3080108@arm.com> <50324345.2070700@net-b.de> In-Reply-To: <50324345.2070700@net-b.de> X-MC-Unique: 112082015135611001 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 20/08/12 15:01, Tobias Burnus wrote: > Hi Richard, > > your patch fails here; I get the build failure: > > /projects/tob/gcc-git/gcc/gcc/tree-ssa-math-opts.c: In function ‘bool > is_widening_mult_rhs_p(tree, tree, tree_node**, tree_node**)’: > /projects/tob/gcc-git/gcc/gcc/tree-ssa-math-opts.c:2014:18: error: > variable ‘rhs_code’ set but not used [-Werror=unused-but-set-variable] > enum tree_code rhs_code; > ^ > > Tobias > > On 08/17/2012 07:05 PM, Richard Earnshaw wrote: >> --- tree-ssa-math-opts.c (revision 190502) >> +++ tree-ssa-math-opts.c (local) > >> @@ -1982,9 +2019,7 @@ is_widening_mult_rhs_p (tree type, tree >> if (is_gimple_assign (stmt)) >> { >> rhs_code = gimple_assign_rhs_code (stmt); >> - if (TREE_CODE (type) == INTEGER_TYPE >> - ? !CONVERT_EXPR_CODE_P (rhs_code) >> - : rhs_code != FIXED_CONVERT_EXPR) >> + if (! widening_mult_conversion_strippable_p (type, stmt)) >> rhs1 = rhs; >> else >> { >> > > Whoops! Sorry about that. Fixed thusly. Committed as obvious. PR tree-ssa/54295 * tree-ssa-math-opts.c (is_widening_mult_rhs_p): Delete rhs_code declaration and setter. R. Index: tree-ssa-math-opts.c =================================================================== --- tree-ssa-math-opts.c (revision 190533) +++ tree-ssa-math-opts.c (working copy) @@ -2011,14 +2011,12 @@ is_widening_mult_rhs_p (tree type, tree { gimple stmt; tree type1, rhs1; - enum tree_code rhs_code; if (TREE_CODE (rhs) == SSA_NAME) { stmt = SSA_NAME_DEF_STMT (rhs); if (is_gimple_assign (stmt)) { - rhs_code = gimple_assign_rhs_code (stmt); if (! widening_mult_conversion_strippable_p (type, stmt)) rhs1 = rhs; else