Patchwork qemu-common: Declare qemu_irq earlier

login
register
mail settings
Submitter Stefan Weil
Date Aug. 20, 2012, 4:45 a.m.
Message ID <1345437900-8001-1-git-send-email-sw@weilnetz.de>
Download mbox | patch
Permalink /patch/178650/
State Superseded
Headers show

Comments

Stefan Weil - Aug. 20, 2012, 4:45 a.m.
This allows using qemu_irq in the target specific cpu.h.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
 qemu-common.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Stefan Hajnoczi - Aug. 24, 2012, 10:54 a.m.
On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
> This allows using qemu_irq in the target specific cpu.h.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  qemu-common.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

I'm not sure if there's a reason why qemu_irq was previously hidden from
cpu.h but the code change itself is fine and no one else has commented.

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan
Peter Maydell - Aug. 24, 2012, 11:06 a.m.
On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>> This allows using qemu_irq in the target specific cpu.h.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  qemu-common.h |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> I'm not sure if there's a reason why qemu_irq was previously hidden from
> cpu.h but the code change itself is fine and no one else has commented.
>
> Thanks, applied to the trivial patches tree:
> https://github.com/stefanha/qemu/commits/trivial-patches

Consensus seemed to be that it was better to move qemu_irq
into hw/irq.h, as discussed in this mail thread:
http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
rather than just doing a move of the typedef within this header.

-- PMM
Stefan Hajnoczi - Aug. 24, 2012, 11:56 a.m.
On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> On 24 August 2012 11:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>> This allows using qemu_irq in the target specific cpu.h.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>> ---
>>>  qemu-common.h |    3 ++-
>>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>> cpu.h but the code change itself is fine and no one else has commented.
>>
>> Thanks, applied to the trivial patches tree:
>> https://github.com/stefanha/qemu/commits/trivial-patches
>
> Consensus seemed to be that it was better to move qemu_irq
> into hw/irq.h, as discussed in this mail thread:
> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
> rather than just doing a move of the typedef within this header.

Fine by me.  I won't send a pull request with this patch yet.

Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?

Stefan
Stefan Weil - Aug. 24, 2012, 5:33 p.m.
Am 24.08.2012 13:56, schrieb Stefan Hajnoczi:
> On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell
> <peter.maydell@linaro.org>  wrote:
>> On 24 August 2012 11:54, Stefan Hajnoczi<stefanha@gmail.com>  wrote:
>>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote:
>>>> This allows using qemu_irq in the target specific cpu.h.
>>>>
>>>> Signed-off-by: Stefan Weil<sw@weilnetz.de>
>>>> ---
>>>>   qemu-common.h |    3 ++-
>>>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> I'm not sure if there's a reason why qemu_irq was previously hidden from
>>> cpu.h but the code change itself is fine and no one else has commented.
>>>
>>> Thanks, applied to the trivial patches tree:
>>> https://github.com/stefanha/qemu/commits/trivial-patches
>>
>> Consensus seemed to be that it was better to move qemu_irq
>> into hw/irq.h, as discussed in this mail thread:
>> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html
>> rather than just doing a move of the typedef within this header.
>
> Fine by me.  I won't send a pull request with this patch yet.
>
> Stefan Weil: Are you happy to use the hw/irq.h patch instead of this?
>
> Stefan

Stefan H., that's OK.

Cheers,
Stefan

Patch

diff --git a/qemu-common.h b/qemu-common.h
index 74a99d3..88a515e 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -19,6 +19,8 @@  struct Monitor;
 typedef struct Monitor Monitor;
 typedef struct MigrationParams MigrationParams;
 
+typedef struct IRQState *qemu_irq;
+
 /* we put basic includes here to avoid repeating them in device drivers */
 #include <stdlib.h>
 #include <stdio.h>
@@ -276,7 +278,6 @@  typedef struct PCIEPort PCIEPort;
 typedef struct PCIESlot PCIESlot;
 typedef struct MSIMessage MSIMessage;
 typedef struct SerialState SerialState;
-typedef struct IRQState *qemu_irq;
 typedef struct PCMCIACardState PCMCIACardState;
 typedef struct MouseTransformInfo MouseTransformInfo;
 typedef struct uWireSlave uWireSlave;