From patchwork Mon Jan 12 00:06:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julian Calaby X-Patchwork-Id: 17865 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 57CB7DE2A1 for ; Mon, 12 Jan 2009 11:27:16 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from outbound.icp-qv1-irony-out1.iinet.net.au (outbound.icp-qv1-irony-out1.iinet.net.au [203.59.1.108]) by ozlabs.org (Postfix) with ESMTP id 54BA2DDEE9 for ; Mon, 12 Jan 2009 11:07:57 +1100 (EST) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Au8AAHIYakl8qHf+/2dsb2JhbAAIjFy4dotGhW8 X-IronPort-AV: E=Sophos;i="4.37,249,1231081200"; d="scan'208";a="439642647" Received: from unknown (HELO [192.168.2.115]) ([124.168.119.254]) by outbound.icp-qv1-irony-out1.iinet.net.au with ESMTP; 12 Jan 2009 09:07:55 +0900 Message-ID: <496A89A1.8050302@gmail.com> Date: Mon, 12 Jan 2009 11:06:57 +1100 From: Julian Calaby User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Anatolij Gustschin Subject: [PATCH] mb862xx: Restrict compliation of platform driver to PPC X-Mailman-Approved-At: Mon, 12 Jan 2009 11:27:01 +1100 Cc: Dmitry Baryshkov , Matteo Fortini , Krzysztof Helt X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org mb862xx: Restrict compliation of platform driver to PPC The OpenFirmware part of this driver is uncompilable on SPARC due to it's dependance on several PPC specific functions. Restricting this to PPC to prevent these build errors. This was found using randconfig builds. Signed-off-by: Julian Calaby Reviewed-by: Anton Vorontsov Acked-by: Anatolij Gustschin --- A couple of notes: 1. After looking at the includes used by this driver, the OF part may not compile cleanly on PPC either as it doesn't appear to pull in the required headers for all the functions and constants it uses. 2. Also, this bug will *not* show up in allmodconfigs or allyesconfigs as the OF part of this driver is prevented from building when the PCI driver is built, and the PCI driver appears first. 3. This patch is over DaveM's sparc-2.6 git tree as of today. 4. I apologise for the massive cross-posting - I am not sure where exactly to send this patch. 5. Please note that I am not a member of any of these lists, so please keep me CC'd. Thanks, Julian Calaby --- drivers/video/Kconfig | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 6372f8b..8f18169 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -2111,6 +2111,7 @@ config FB_MB862XX_LIME bool "Lime GDC" depends on FB_MB862XX depends on OF && !FB_MB862XX_PCI_GDC + depends on PPC select FB_FOREIGN_ENDIAN select FB_LITTLE_ENDIAN ---help---