Patchwork [Precise,3/5] be2net: Fix Endian

login
register
mail settings
Submitter Jesse Sung
Date Aug. 20, 2012, 3:54 a.m.
Message ID <39b945b9b996b212370751b1f02f65ff4fff129c.1345433485.git.jesse.sung@canonical.com>
Download mbox | patch
Permalink /patch/178647/
State New
Headers show

Comments

Jesse Sung - Aug. 20, 2012, 3:54 a.m.
From: Li RongQing <roy.qing.li@gmail.com>

BugLink: https://launchpad.net/bugs/1035348

ETH_P_IP is host Endian, skb->protocol is big Endian, when
compare them, we should change ETH_P_IP from host endian
to big endian, htons, not ntohs.

CC: Somnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Somnath Kotur <somnath.kotur@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit e8efcec5394cbf7ae67ccb137cb1a45ae3e6f6c8)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 drivers/net/ethernet/emulex/benet/be.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be.h b/drivers/net/ethernet/emulex/benet/be.h
index a244f2f..2a64de3 100644
--- a/drivers/net/ethernet/emulex/benet/be.h
+++ b/drivers/net/ethernet/emulex/benet/be.h
@@ -518,7 +518,7 @@  static inline void be_check_sriov_fn_type(struct be_adapter *adapter)
 
 static inline bool is_ipv4_pkt(struct sk_buff *skb)
 {
-	return skb->protocol == ntohs(ETH_P_IP) && ip_hdr(skb)->version == 4;
+	return skb->protocol == htons(ETH_P_IP) && ip_hdr(skb)->version == 4;
 }
 
 static inline void be_vf_eth_addr_generate(struct be_adapter *adapter, u8 *mac)