Patchwork [Precise,1/5] be2net: reduce gso_max_size setting to account for ethernet header.

login
register
mail settings
Submitter Jesse Sung
Date Aug. 20, 2012, 3:54 a.m.
Message ID <349024d7fa11333093d09a518dcbbc371c296700.1345433485.git.jesse.sung@canonical.com>
Download mbox | patch
Permalink /patch/178646/
State New
Headers show

Comments

Jesse Sung - Aug. 20, 2012, 3:54 a.m.
From: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>

BugLink: https://launchpad.net/bugs/1035348

The maximum size of packet that can be handled by controller including ethernet
header is 65535. Reducing gso_max_size accordingly.

Signed-off-by: Sarveshwar Bandi <sarveshwar.bandi@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit b7e5887e0e414bde0a2f311ae3fbea5611562e29)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 drivers/net/ethernet/emulex/benet/be_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Tim Gardner - Aug. 20, 2012, 12:58 p.m.
Seems like all of these ought to be coming via stable. Have you 
mentioned any of these patches on the stable mailing list?

rtg
Seth Forshee - Aug. 20, 2012, 1:13 p.m.
Ack for the whole series.
Tim Gardner - Aug. 20, 2012, 1:29 p.m.
Are you sure http://bugs.launchpad.net/bugs/1035348 is the right bug
number ?
Jesse Sung - Aug. 21, 2012, 2:49 a.m.
2012/8/20 Tim Gardner <tim.gardner@canonical.com>:
> Seems like all of these ought to be coming via stable. Have you mentioned
> any of these patches on the stable mailing list?

No, I haven't. Should I send them to stable instead of SRU?

Thanks,
Jesse
Jesse Sung - Aug. 21, 2012, 2:51 a.m.
2012/8/20 Tim Gardner <tim.gardner@canonical.com>:
> Are you sure http://bugs.launchpad.net/bugs/1035348 is the right bug
> number ?

It's a private bug in the beginning, and it's public now. Sorry for that.

Thanks,
Jesse
Tim Gardner - Aug. 21, 2012, 1:53 p.m.
On 08/20/2012 08:49 PM, Jesse Sung wrote:
> 2012/8/20 Tim Gardner <tim.gardner@canonical.com>:
>> Seems like all of these ought to be coming via stable. Have you mentioned
>> any of these patches on the stable mailing list?
>
> No, I haven't. Should I send them to stable instead of SRU?
>
> Thanks,
> Jesse
>

Lets do both so that the rest of the community can benefit. You might 
want to refresh your memory of stable procedures by reviewing 
Documentation/stable_kernel_rules.txt in the kernel repo. Be sure to 
mention to which kernel version(s) that these patches apply.

rtg
Tim Gardner - Aug. 21, 2012, 2:06 p.m.
Applied all 5 patches

Patch

diff --git a/drivers/net/ethernet/emulex/benet/be_main.c b/drivers/net/ethernet/emulex/benet/be_main.c
index 77c536e..32c1ad4 100644
--- a/drivers/net/ethernet/emulex/benet/be_main.c
+++ b/drivers/net/ethernet/emulex/benet/be_main.c
@@ -3103,7 +3103,7 @@  static void be_netdev_init(struct net_device *netdev)
 
 	netdev->flags |= IFF_MULTICAST;
 
-	netif_set_gso_max_size(netdev, 65535);
+	netif_set_gso_max_size(netdev, 65535 - ETH_HLEN);
 
 	BE_SET_NETDEV_OPS(netdev, &be_netdev_ops);