Patchwork [U-Boot] usb: fix ulpi_set_vbus prototype

login
register
mail settings
Submitter Lucas Stach
Date Aug. 19, 2012, 4:22 p.m.
Message ID <1345393327-29251-1-git-send-email-dev@lynxeye.de>
Download mbox | patch
Permalink /patch/178574/
State Accepted
Commit 749f8180c2b516abefdda3f5833d39f49b60f84d
Delegated to: Marek Vasut
Headers show

Comments

Lucas Stach - Aug. 19, 2012, 4:22 p.m.
Match the name of the header prototype with the actual
implementation.

Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
 include/usb/ulpi.h | 2 +-
 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
Marek Vasut - Aug. 19, 2012, 4:44 p.m.
Dear Lucas Stach,

> Match the name of the header prototype with the actual
> implementation.

Applied, thanks

> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
>  include/usb/ulpi.h | 2 +-
>  1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
> 
> diff --git a/include/usb/ulpi.h b/include/usb/ulpi.h
> index 4a23fd2..9a75c24 100644
> --- a/include/usb/ulpi.h
> +++ b/include/usb/ulpi.h
> @@ -61,7 +61,7 @@ int ulpi_select_transceiver(struct ulpi_viewport
> *ulpi_vp, unsigned speed); *
>   * returns 0 on success, ULPI_ERROR on failure.
>   */
> -int ulpi_enable_vbus(struct ulpi_viewport *ulpi_vp,
> +int ulpi_set_vbus(struct ulpi_viewport *ulpi_vp,
>  			int on, int ext_power, int ext_ind);
> 
>  /*

Best regards,
Marek Vasut
Igor Grinberg - Aug. 20, 2012, 9:57 a.m.
On 08/19/12 19:22, Lucas Stach wrote:
> Match the name of the header prototype with the actual
> implementation.
> 
> Signed-off-by: Lucas Stach <dev@lynxeye.de>

Good catch! Thanks!

Marek, if it is not too late then:

Acked-by: Igor Grinberg <grinberg@compulab.co.il>

If it is too late, then don't bother...
Marek Vasut - Aug. 20, 2012, 1:46 p.m.
Dear Igor Grinberg,

> On 08/19/12 19:22, Lucas Stach wrote:
> > Match the name of the header prototype with the actual
> > implementation.
> > 
> > Signed-off-by: Lucas Stach <dev@lynxeye.de>
> 
> Good catch! Thanks!
> 
> Marek, if it is not too late then:
> 
> Acked-by: Igor Grinberg <grinberg@compulab.co.il>
> 
> If it is too late, then don't bother...

Already applied it, but thanks!

Best regards,
Marek Vasut

Patch

diff --git a/include/usb/ulpi.h b/include/usb/ulpi.h
index 4a23fd2..9a75c24 100644
--- a/include/usb/ulpi.h
+++ b/include/usb/ulpi.h
@@ -61,7 +61,7 @@  int ulpi_select_transceiver(struct ulpi_viewport *ulpi_vp, unsigned speed);
  *
  * returns 0 on success, ULPI_ERROR on failure.
  */
-int ulpi_enable_vbus(struct ulpi_viewport *ulpi_vp,
+int ulpi_set_vbus(struct ulpi_viewport *ulpi_vp,
 			int on, int ext_power, int ext_ind);
 
 /*