| Message ID | alpine.DEB.2.02.1208191149400.2031@localhost6.localdomain6 |
|---|---|
| State | Not Applicable, archived |
| Delegated to: | David Miller |
| Headers | show |
On 19 August 2012 13:49, Julia Lawall <julia.lawall@lip6.fr> wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > The result of one call to a function is tested, and then at the second call > to the same function, the previous result, and not the current result, is > tested again. > > Also changed &bssid to bssid, at the suggestion of Stanislav Yakovlev. > > The semantic match that finds the first problem is as follows: > > (http://coccinelle.lip6.fr/) > > // <smpl> > @@ > expression ret; > identifier f; > statement S1,S2; > @@ > > *ret = f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S1 > ... when any > *f(...); > if (\(ret != 0\|ret < 0\|ret == NULL\)) S2 > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > v2: changed &bssid to bssid > Thank you, Julia. Stanislav. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/ipw2x00/ipw2100.c b/drivers/net/wireless/ipw2x00/ipw2100.c index 8a34202..534e655 100644 --- a/drivers/net/wireless/ipw2x00/ipw2100.c +++ b/drivers/net/wireless/ipw2x00/ipw2100.c @@ -2042,7 +2042,8 @@ static void isr_indicate_associated(struct ipw2100_priv *priv, u32 status) return; } len = ETH_ALEN; - ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, &bssid, &len); + ret = ipw2100_get_ordinal(priv, IPW_ORD_STAT_ASSN_AP_BSSID, bssid, + &len); if (ret) { IPW_DEBUG_INFO("failed querying ordinals at line %d\n", __LINE__);