diff mbox

[U-Boot,1/2] patman: Use reverse order for changelog

Message ID 1345311965-24414-1-git-send-email-otavio@ossystems.com.br
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Otavio Salvador Aug. 18, 2012, 5:46 p.m. UTC
Specially when many revisions are need for a patchset, the most
interesting information is about the last set of changes so we output
the changelog in reverse order to easy identification of most recent
change set.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 tools/patman/series.py |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Glass Sept. 18, 2012, 6:10 p.m. UTC | #1
On Sat, Aug 18, 2012 at 10:46 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Specially when many revisions are need for a patchset, the most
> interesting information is about the last set of changes so we output
> the changelog in reverse order to easy identification of most recent
> change set.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Acked-by: Simon Glass <sjg@chromium.org>

> ---
>  tools/patman/series.py |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tools/patman/series.py b/tools/patman/series.py
> index 7829dc7..dddfab4 100644
> --- a/tools/patman/series.py
> +++ b/tools/patman/series.py
> @@ -145,18 +145,18 @@ class Series(dict):
>          Return:
>              The change log as a list of strings, one per line
>
> +            Changes in v2:
> +            - Jog the dial back closer to the widget
> +
>              Changes in v1:
>              - Fix the widget
>              - Jog the dial
>
> -            Changes in v2:
> -            - Jog the dial back closer to the widget
> -
>              etc.
>          """
>          final = []
>          need_blank = False
> -        for change in sorted(self.changes):
> +        for change in sorted(self.changes, reverse=True):
>              out = []
>              for this_commit, text in self.changes[change]:
>                  if commit and this_commit != commit:
> --
> 1.7.10.4
>
Tom Rini Sept. 27, 2012, 4:21 p.m. UTC | #2
On Sat, Aug 18, 2012 at 07:46:04AM -0000, Otavio Salvador wrote:

> Specially when many revisions are need for a patchset, the most
> interesting information is about the last set of changes so we output
> the changelog in reverse order to easy identification of most recent
> change set.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Acked-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/patman/series.py b/tools/patman/series.py
index 7829dc7..dddfab4 100644
--- a/tools/patman/series.py
+++ b/tools/patman/series.py
@@ -145,18 +145,18 @@  class Series(dict):
         Return:
             The change log as a list of strings, one per line
 
+            Changes in v2:
+            - Jog the dial back closer to the widget
+
             Changes in v1:
             - Fix the widget
             - Jog the dial
 
-            Changes in v2:
-            - Jog the dial back closer to the widget
-
             etc.
         """
         final = []
         need_blank = False
-        for change in sorted(self.changes):
+        for change in sorted(self.changes, reverse=True):
             out = []
             for this_commit, text in self.changes[change]:
                 if commit and this_commit != commit: