Patchwork [U-Boot,v3] patman: Do not Cc addresses included in To list

login
register
mail settings
Submitter Otavio Salvador
Date Aug. 18, 2012, 5:19 p.m.
Message ID <1345310391-21286-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/178474/
State Accepted
Commit 43de0244c133b6cb9041ae6e7e4ae79839f22c44
Headers show

Comments

Otavio Salvador - Aug. 18, 2012, 5:19 p.m.
In case an address is listed in the To list, those will be skipped on
Cc list or user might end with a duplicated message.

This fixes the case when a tag points to same address used as series
destination thus avoiding duplicated sending.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v2:
- use if 'to' in self: to remove the try block

Changes in v3:
- readd try / except block to handle the valid error

 tools/patman/series.py |    7 +++++++
 1 file changed, 7 insertions(+)
Wolfgang Denk - Sept. 2, 2012, 2:27 p.m.
Dear Otavio Salvador,

In message <1345310391-21286-1-git-send-email-otavio@ossystems.com.br> you wrote:
> In case an address is listed in the To list, those will be skipped on
> Cc list or user might end with a duplicated message.
> 
> This fixes the case when a tag points to same address used as series
> destination thus avoiding duplicated sending.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v2:
> - use if 'to' in self: to remove the try block
> 
> Changes in v3:
> - readd try / except block to handle the valid error
> 
>  tools/patman/series.py |    7 +++++++
>  1 file changed, 7 insertions(+)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/tools/patman/series.py b/tools/patman/series.py
index eda1e9b..7829dc7 100644
--- a/tools/patman/series.py
+++ b/tools/patman/series.py
@@ -114,6 +114,13 @@  class Series(dict):
                 cc_list += gitutil.BuildEmailList(commit.tags)
             cc_list += gitutil.BuildEmailList(commit.cc_list)
 
+            # Skip items in To list
+            if 'to' in self:
+                try:
+                    map(cc_list.remove, gitutil.BuildEmailList(self.to))
+                except ValueError:
+                    pass
+
             for email in cc_list:
                 if email == None:
                     email = col.Color(col.YELLOW, "<alias '%s' not found>"