Patchwork ifplugd: add --with-initdir= to config command

login
register
mail settings
Submitter Shawn J. Goff
Date Aug. 18, 2012, 2:04 p.m.
Message ID <1345298656-12714-1-git-send-email-shawnjgoff@gmail.com>
Download mbox | patch
Permalink /patch/178467/
State Accepted
Headers show

Comments

Shawn J. Goff - Aug. 18, 2012, 2:04 p.m.
From: "Shawn J. Goff" <shawnjgoff@gmail.com>

ifplugd refuses to configure without this set.
---
 package/ifplugd/ifplugd.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Thomas Petazzoni - Aug. 21, 2012, 9:56 a.m.
Le Sat, 18 Aug 2012 10:04:16 -0400,
"Shawn J. Goff" <shawnjgoff@gmail.com> a écrit :

> From: "Shawn J. Goff" <shawnjgoff@gmail.com>
> 
> ifplugd refuses to configure without this set.

When you say "configure", do you mean the execution of the configure
script at build time, or the startup of ifplugd on the target?

Thanks!

Thomas
Shawn J. Goff - Aug. 21, 2012, 1:12 p.m.
I mean the configure script fails when building the package.

On Tue, Aug 21, 2012 at 5:56 AM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:

> Le Sat, 18 Aug 2012 10:04:16 -0400,
> "Shawn J. Goff" <shawnjgoff@gmail.com> a écrit :
>
> > From: "Shawn J. Goff" <shawnjgoff@gmail.com>
> >
> > ifplugd refuses to configure without this set.
>
> When you say "configure", do you mean the execution of the configure
> script at build time, or the startup of ifplugd on the target?
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>
Thomas Petazzoni - Aug. 22, 2012, 7:54 a.m.
Le Tue, 21 Aug 2012 09:12:46 -0400,
Shawn Goff <shawnjgoff@gmail.com> a écrit :

> I mean the configure script fails when building the package.

It builds fine here. What problem do you encounter, and with what
configuration?

Thomas
Shawn J. Goff - Aug. 22, 2012, 12:39 p.m.
Error:
configure: error: missing --with-initdir=DIR
full output from make: http://sprunge.us/eRQT

Config:
http://sprunge.us/TITZ

On Wed, Aug 22, 2012 at 3:54 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
>
> Le Tue, 21 Aug 2012 09:12:46 -0400,
> Shawn Goff <shawnjgoff@gmail.com> a écrit :
>
> > I mean the configure script fails when building the package.
>
> It builds fine here. What problem do you encounter, and with what
> configuration?
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
Thomas Petazzoni - Aug. 24, 2012, 9:46 p.m.
Le Wed, 22 Aug 2012 08:39:55 -0400,
Shawn Goff <shawnjgoff@gmail.com> a écrit :

> Error:
> configure: error: missing --with-initdir=DIR
> full output from make: http://sprunge.us/eRQT

Ok. It was working here because the ./configure script of ifplug looks
at /etc on the build system to see if /etc/init.d exists. Since it's
the case on my machine, it did work. But apparently, it's not the case
on yours, and it's not good to depend on such thing from the build
machine, so I applied your patch.

Thanks!

Thomas

Patch

diff --git a/package/ifplugd/ifplugd.mk b/package/ifplugd/ifplugd.mk
index 1e11c14..d031a97 100644
--- a/package/ifplugd/ifplugd.mk
+++ b/package/ifplugd/ifplugd.mk
@@ -12,7 +12,7 @@  IFPLUGD_AUTORECONF = YES
 
 # install-strip unconditionally overwrites $(TARGET_DIR)/etc/ifplugd/ifplugd.*
 IFPLUGD_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install-exec
-IFPLUGD_CONF_OPT = --disable-lynx
+IFPLUGD_CONF_OPT = --disable-lynx --with-initdir=/etc/init.d/
 IFPLUGD_DEPENDENCIES = libdaemon
 
 # Prefer big ifplugd