Patchwork more bitmap obstacks

login
register
mail settings
Submitter Steven Bosscher
Date Aug. 18, 2012, 10:28 a.m.
Message ID <CABu31nNZDCBehRUZzDfz_X+2v4xyxtCfT=xLqmJXT25Yyq8r9w@mail.gmail.com>
Download mbox | patch
Permalink /patch/178443/
State New
Headers show

Comments

Steven Bosscher - Aug. 18, 2012, 10:28 a.m.
On Sat, Aug 18, 2012 at 12:21 PM, Tobias Burnus <burnus@net-b.de> wrote:
> I filled a small bug report at
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54313

Yup, thanks.

        * dse.c (dse_step7): Don't free kill_on_calls bitmap, it is
freed when its obstack is release.
Richard Guenther - Aug. 18, 2012, 10:39 a.m.
On Sat, Aug 18, 2012 at 12:28 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> On Sat, Aug 18, 2012 at 12:21 PM, Tobias Burnus <burnus@net-b.de> wrote:
>> I filled a small bug report at
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54313
>
> Yup, thanks.
>
>         * dse.c (dse_step7): Don't free kill_on_calls bitmap, it is
> freed when its obstack is release.

Looks obvious.

> Index: dse.c
> ===================================================================
> --- dse.c       (revision 190475)
> +++ dse.c       (working copy)
> @@ -3823,7 +3823,6 @@ dse_step7 (void)
>    VEC_free (group_info_t, heap, rtx_group_vec);
>    BITMAP_FREE (all_blocks);
>    BITMAP_FREE (scratch);
> -  BITMAP_FREE (kill_on_calls);
>
>    free_alloc_pool (rtx_store_info_pool);
>    free_alloc_pool (read_info_pool);
Steven Bosscher - Aug. 18, 2012, 10:39 a.m.
On Sat, Aug 18, 2012 at 12:39 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Sat, Aug 18, 2012 at 12:28 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> On Sat, Aug 18, 2012 at 12:21 PM, Tobias Burnus <burnus@net-b.de> wrote:
>>> I filled a small bug report at
>>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54313
>>
>> Yup, thanks.
>>
>>         * dse.c (dse_step7): Don't free kill_on_calls bitmap, it is
>> freed when its obstack is release.
>
> Looks obvious.

Yes, I already committed it.

Patch

Index: dse.c
===================================================================
--- dse.c       (revision 190475)
+++ dse.c       (working copy)
@@ -3823,7 +3823,6 @@  dse_step7 (void)
   VEC_free (group_info_t, heap, rtx_group_vec);
   BITMAP_FREE (all_blocks);
   BITMAP_FREE (scratch);
-  BITMAP_FREE (kill_on_calls);

   free_alloc_pool (rtx_store_info_pool);
   free_alloc_pool (read_info_pool);