From patchwork Fri Aug 17 23:36:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 178416 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9EA1D2C009C for ; Sat, 18 Aug 2012 14:17:54 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757753Ab2HQXgn (ORCPT ); Fri, 17 Aug 2012 19:36:43 -0400 Received: from mail-ob0-f202.google.com ([209.85.214.202]:34062 "EHLO mail-ob0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755445Ab2HQXgm (ORCPT ); Fri, 17 Aug 2012 19:36:42 -0400 Received: by mail-ob0-f202.google.com with SMTP id wc20so3010724obb.1 for ; Fri, 17 Aug 2012 16:36:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding; bh=CSnRfsQA+Qeo5J440UfOM9M2mqK9BiOLXchn6GgPs/E=; b=eJ5T0Zt4ABEcJ0AygZLSH09SlG7SMGfPJF96+6ZqknlE4YmrLXEsGmOzVT9ES6qVk3 DqLcT6R2WFsPqSR1sLv2esxXZpG5faEZkpwsSHBf4PgIMTM3h+prar2W18tYNwpXNmGT uSlOJJBqyAfHmeVmLYvFDrKhltZ7o538qzqEppUKC+wFvEtK7ppDMhbrZJ+UgnzXaPzp XPM/Ck9fYMxywuTFDR3HI1/UZKfyLkS4Ca/PFNCmvQbivTOdCZ8S1O6fr3RuDAWq/Jca jP0hTtvIgI5CdwOgDYpwcbzsRXvbqub6qrWi89z5S1/RMnbVEjeVr10Yr1oeYZbLPppk Mrmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:from:cc:date:message-id:in-reply-to:references :user-agent:mime-version:content-type:content-transfer-encoding :x-gm-message-state; bh=CSnRfsQA+Qeo5J440UfOM9M2mqK9BiOLXchn6GgPs/E=; b=J6EmWlJOl7M+SA3PkfU68KVnVpH9yLFsbAkTUA1cyZBxrTvKPAFib8foKZJau29FNP 5Xl6clsgulEIdZCN7JS1l6eVh3Z8m72R5b+ZCG/D/8ZuTA17Cu8PCqcf0CbqET11r1MC 2Fyqf8CZh9zLCc2OgkD5Ia7K9d+UCBYmAw/s5XojsZbHqaoeF8+2Qt0poHEt9Jm2RugS E1viGthP7xh3cquSpyyK7mEA96YdumYjOu097ajiC4xd01EG8rU3+0ze3HAcjYx4y7b3 s72FOiS4ruNs7MrjBXSZ/eCQRKs6XkN06X3t9rSnjlLJT8AVnoX/CXTl3SeNVw7dskjZ gfJw== Received: by 10.43.46.202 with SMTP id up10mr2673793icb.9.1345246602381; Fri, 17 Aug 2012 16:36:42 -0700 (PDT) Received: by 10.43.46.202 with SMTP id up10mr2673783icb.9.1345246602328; Fri, 17 Aug 2012 16:36:42 -0700 (PDT) Received: from wpzn3.hot.corp.google.com (216-239-44-65.google.com [216.239.44.65]) by gmr-mx.google.com with ESMTPS id dd6si550558igc.0.2012.08.17.16.36.42 (version=TLSv1/SSLv3 cipher=AES128-SHA); Fri, 17 Aug 2012 16:36:42 -0700 (PDT) Received: from bhelgaas.mtv.corp.google.com (bhelgaas.mtv.corp.google.com [172.18.96.155]) by wpzn3.hot.corp.google.com (Postfix) with ESMTP id EAAF4100047; Fri, 17 Aug 2012 16:36:41 -0700 (PDT) Received: from bhelgaas.mtv.corp.google.com (unknown [IPv6:::1]) by bhelgaas.mtv.corp.google.com (Postfix) with ESMTP id 962391801BB; Fri, 17 Aug 2012 16:36:41 -0700 (PDT) Subject: [PATCH v2 11/16] PCI: Leave normal LIST_POISON in deleted list entries To: linux-pci@vger.kernel.org From: Bjorn Helgaas Cc: linux-pcmcia@lists.infradead.org, Yinghai Lu , Kenji Kaneshige Date: Fri, 17 Aug 2012 17:36:41 -0600 Message-ID: <20120817233641.10973.93668.stgit@bhelgaas.mtv.corp.google.com> In-Reply-To: <20120817233100.10973.59521.stgit@bhelgaas.mtv.corp.google.com> References: <20120817233100.10973.59521.stgit@bhelgaas.mtv.corp.google.com> User-Agent: StGit/0.15 MIME-Version: 1.0 X-Gm-Message-State: ALoCoQlsHe1nezy7a4ASubUc/tOKT1THTuWcFH2HlpN1u/8G/5ohRvPFX2kz0+rJ3GAnNCFqlmLnIeYgGCHUtnprYbVzQctrcZQMfPkNeO6uCDmurw8ygVQNp/CbSm8AhTDPvGRi4tXBp15PihYP9JccSMzhTlEnIQG3LAf4oObw1AO5uV4kA5+903FdhG7UQ3GXw1QrzJTS2PKWa8BYYH7uFDpai6ZWcA== Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org list_del() already sets next/prev to LIST_POISON1/LIST_POISON2, so we don't need to do anything special here to prevent further list accesses. Signed-off-by: Bjorn Helgaas --- drivers/pci/remove.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c index c01baca..4f9ca91 100644 --- a/drivers/pci/remove.c +++ b/drivers/pci/remove.c @@ -32,11 +32,8 @@ static void pci_stop_dev(struct pci_dev *dev) static void pci_destroy_dev(struct pci_dev *dev) { - /* Remove the device from the device lists, and prevent any further - * list accesses from this device */ down_write(&pci_bus_sem); list_del(&dev->bus_list); - dev->bus_list.next = dev->bus_list.prev = NULL; up_write(&pci_bus_sem); pci_free_resources(dev);