[v2,04/16] PCI: Don't export stop_bus_device and remove_bus_device interfaces

Submitted by Bjorn Helgaas on Aug. 17, 2012, 11:36 p.m.


Message ID 20120817233605.10973.85918.stgit@bhelgaas.mtv.corp.google.com
State Superseded
Headers show

Commit Message

Bjorn Helgaas Aug. 17, 2012, 11:36 p.m.
The acpiphp hotplug driver was the only user of pci_stop_bus_device() and
__pci_remove_bus_device(), and it now uses pci_stop_and_remove_bus_device()
instead, so stop exposing these interfaces.

This removes these exported symbols:


Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
 drivers/pci/remove.c |    8 ++++----
 include/linux/pci.h  |    2 --
 2 files changed, 4 insertions(+), 6 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch hide | download patch | download mbox

diff --git a/drivers/pci/remove.c b/drivers/pci/remove.c
index 04a4861..534377f 100644
--- a/drivers/pci/remove.c
+++ b/drivers/pci/remove.c
@@ -79,6 +79,8 @@  void pci_remove_bus(struct pci_bus *pci_bus)
 static void __pci_remove_behind_bridge(struct pci_dev *dev);
+static void pci_stop_bus_device(struct pci_dev *dev);
  * pci_stop_and_remove_bus_device - remove a PCI device and any children
  * @dev: the device to remove
@@ -91,7 +93,7 @@  static void __pci_remove_behind_bridge(struct pci_dev *dev);
  * device lists, remove the /proc entry, and notify userspace
  * (/sbin/hotplug).
-void __pci_remove_bus_device(struct pci_dev *dev)
+static void __pci_remove_bus_device(struct pci_dev *dev)
 	if (dev->subordinate) {
 		struct pci_bus *b = dev->subordinate;
@@ -103,7 +105,6 @@  void __pci_remove_bus_device(struct pci_dev *dev)
 void pci_stop_and_remove_bus_device(struct pci_dev *dev)
@@ -170,7 +171,7 @@  static void pci_stop_bus_devices(struct pci_bus *bus)
  * and so on). This also stop any subordinate buses and children in a
  * depth-first manner.
-void pci_stop_bus_device(struct pci_dev *dev)
+static void pci_stop_bus_device(struct pci_dev *dev)
 	if (dev->subordinate)
@@ -180,4 +181,3 @@  void pci_stop_bus_device(struct pci_dev *dev)
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 5faa831..54b5b2b 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -734,9 +734,7 @@  u8 pci_common_swizzle(struct pci_dev *dev, u8 *pinp);
 extern struct pci_dev *pci_dev_get(struct pci_dev *dev);
 extern void pci_dev_put(struct pci_dev *dev);
 extern void pci_remove_bus(struct pci_bus *b);
-extern void __pci_remove_bus_device(struct pci_dev *dev);
 extern void pci_stop_and_remove_bus_device(struct pci_dev *dev);
-extern void pci_stop_bus_device(struct pci_dev *dev);
 void pci_setup_cardbus(struct pci_bus *bus);
 extern void pci_sort_breadthfirst(void);
 #define dev_is_pci(d) ((d)->bus == &pci_bus_type)