From patchwork Fri Aug 17 17:53:37 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Habkost X-Patchwork-Id: 178290 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 0C1C32C0099 for ; Sat, 18 Aug 2012 03:53:51 +1000 (EST) Received: from localhost ([::1]:59402 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2Qk1-0001wP-6G for incoming@patchwork.ozlabs.org; Fri, 17 Aug 2012 13:53:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52594) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2Qj1-0007VJ-Um for qemu-devel@nongnu.org; Fri, 17 Aug 2012 13:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2Qiy-0007h8-OW for qemu-devel@nongnu.org; Fri, 17 Aug 2012 13:52:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2Qiy-0007gk-Ew for qemu-devel@nongnu.org; Fri, 17 Aug 2012 13:52:44 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7HHqere014874 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 17 Aug 2012 13:52:40 -0400 Received: from blackpad.lan.raisama.net (vpn1-6-17.gru2.redhat.com [10.97.6.17]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7HHqd2i005387; Fri, 17 Aug 2012 13:52:40 -0400 Received: by blackpad.lan.raisama.net (Postfix, from userid 500) id 7693520116E; Fri, 17 Aug 2012 14:53:44 -0300 (BRT) From: Eduardo Habkost To: qemu-devel@nongnu.org Date: Fri, 17 Aug 2012 14:53:37 -0300 Message-Id: <1345226022-21654-2-git-send-email-ehabkost@redhat.com> In-Reply-To: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> References: <1345226022-21654-1-git-send-email-ehabkost@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, gleb@redhat.com, jan.kiszka@siemens.com, mtosatti@redhat.com, mdroth@linux.vnet.ibm.com, blauwirbel@gmail.com, avi@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de Subject: [Qemu-devel] [RFC 1/6] x86_cpudef_setup: coding style change X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Make source code lines shorter. Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- target-i386/cpu.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 96ec9e6..519a104 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1500,20 +1500,23 @@ void x86_cpudef_setup(void) static const char *model_with_versions[] = { "qemu32", "qemu64", "athlon" }; for (i = 0; i < ARRAY_SIZE(builtin_x86_defs); ++i) { - builtin_x86_defs[i].next = x86_defs; - builtin_x86_defs[i].flags = 1; + x86_def_t *def = &builtin_x86_defs[i]; + def->next = x86_defs; + def->flags = 1; /* Look for specific "cpudef" models that */ /* have the QEMU version in .model_id */ for (j = 0; j < ARRAY_SIZE(model_with_versions); j++) { - if (strcmp(model_with_versions[j], builtin_x86_defs[i].name) == 0) { - pstrcpy(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), "QEMU Virtual CPU version "); - pstrcat(builtin_x86_defs[i].model_id, sizeof(builtin_x86_defs[i].model_id), qemu_get_version()); + if (strcmp(model_with_versions[j], def->name) == 0) { + pstrcpy(def->model_id, sizeof(def->model_id), + "QEMU Virtual CPU version "); + pstrcat(def->model_id, sizeof(def->model_id), + qemu_get_version()); break; } } - x86_defs = &builtin_x86_defs[i]; + x86_defs = def; } #if !defined(CONFIG_USER_ONLY) qemu_opts_foreach(qemu_find_opts("cpudef"), cpudef_register, NULL, 0);