Patchwork [v5,1.2,queue,2/4] qxl: disallow unknown revisions

login
register
mail settings
Submitter Alon Levy
Date Aug. 17, 2012, 11:50 a.m.
Message ID <1345204252-8205-3-git-send-email-alevy@redhat.com>
Download mbox | patch
Permalink /patch/178190/
State New
Headers show

Comments

Alon Levy - Aug. 17, 2012, 11:50 a.m.
Signed-off-by: Alon Levy <alevy@redhat.com>
---
 hw/qxl.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch

diff --git a/hw/qxl.c b/hw/qxl.c
index 6c48eb9..c978f5e 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1797,10 +1797,13 @@  static int qxl_init_common(PCIQXLDevice *qxl)
         io_size = 16;
         break;
     case 3: /* qxl-3 */
-    default:
         pci_device_rev = QXL_DEFAULT_REVISION;
         io_size = msb_mask(QXL_IO_RANGE_SIZE * 2 - 1);
         break;
+    default:
+        error_report("Invalid revision %d for qxl device (max %d)",
+                     qxl->revision, QXL_DEFAULT_REVISION);
+        return -1;
     }
 
     pci_set_byte(&config[PCI_REVISION_ID], pci_device_rev);