From patchwork Fri Aug 17 11:50:49 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alon Levy X-Patchwork-Id: 178188 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id DFAF62C00A0 for ; Fri, 17 Aug 2012 21:51:13 +1000 (EST) Received: from localhost ([::1]:35835 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2L55-0001Aw-Ue for incoming@patchwork.ozlabs.org; Fri, 17 Aug 2012 07:51:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41059) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2L4t-0001Am-Un for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:51:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T2L4s-0002uO-Vt for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:50:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:9494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T2L4s-0002tJ-OS for qemu-devel@nongnu.org; Fri, 17 Aug 2012 07:50:58 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7HBow0A022261 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Aug 2012 07:50:58 -0400 Received: from garlic.redhat.com (vpn-11-105.rdu.redhat.com [10.11.11.105]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7HBorAu018954; Fri, 17 Aug 2012 07:50:56 -0400 From: Alon Levy To: qemu-devel@nongnu.org, kraxel@redhat.com Date: Fri, 17 Aug 2012 14:50:49 +0300 Message-Id: <1345204252-8205-2-git-send-email-alevy@redhat.com> In-Reply-To: <1345204252-8205-1-git-send-email-alevy@redhat.com> References: <1345204252-8205-1-git-send-email-alevy@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v5 1.2 queue 1/4] qxl/update_area_io: guest_bug on invalid parameters X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Signed-off-by: Alon Levy --- hw/qxl.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6 +1385,18 @@ async_common: QXLCookie *cookie = NULL; QXLRect update = d->ram->update_area; + if (d->ram->update_surface > NUM_SURFACES) { + qxl_set_guest_bug(d, "QXL_IO_UPDATE_AREA: invalid surface id %d\n", + d->ram->update_surface); + return; + } + if (update.left >= update.right || update.top >= update.bottom) { + qxl_set_guest_bug(d, + "QXL_IO_UPDATE_AREA: invalid area (%ux%u)x(%ux%u)\n", + update.left, update.top, update.right, update.bottom); + return; + } + if (async == QXL_ASYNC) { cookie = qxl_cookie_new(QXL_COOKIE_TYPE_IO, QXL_IO_UPDATE_AREA_ASYNC);