Patchwork 2.6.29-rc1: Reported regressions from 2.6.28

login
register
mail settings
Submitter Ingo Molnar
Date Jan. 11, 2009, 1:52 p.m.
Message ID <20090111135237.GA20184@elte.hu>
Download mbox | patch
Permalink /patch/17805/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Ingo Molnar - Jan. 11, 2009, 1:52 p.m.
* Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:

> On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >
> > Regressions with patches
> > ------------------------
> >
> > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> > Subject         : Build error on latest git
> > Submitter       : Petr Titera <P.Titera@century.cz>
> > Date            : 2009-01-11 9:49 (1 days old)
> > References      : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> > Handled-By      : Petr Titera <P.Titera@century.cz>
> > Patch           : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> 
> This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP 
> is defined.
> 
> I am still in the process of cleaning non-smp data from asm/smp.h for 
> x86
> 
> Attach patch is the solution for the time being
> 
> Ingo, can you please put this in urgent queue.

yes, it already is - see below.

	Ingo

----------------->
From 8b5a33599c541cf5bf66304343d08ff2795d038b Mon Sep 17 00:00:00 2001
From: Jaswinder Singh Rajput <jaswinder@infradead.org>
Date: Sun, 11 Jan 2009 18:38:55 +0530
Subject: [PATCH] x86: fix mpparse.c build error on latest git

Fix this by reintroducing asm/smp.h include in mpparse.c - later on
I will fix this by removing non-smp data from smp.h.

Reported-by: Petr Titera <P.Titera@century.cz>
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/mpparse.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki - Jan. 11, 2009, 7 p.m.
On Sunday 11 January 2009, Ingo Molnar wrote:
> 
> * Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> 
> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > >
> > > Regressions with patches
> > > ------------------------
> > >
> > > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> > > Subject         : Build error on latest git
> > > Submitter       : Petr Titera <P.Titera@century.cz>
> > > Date            : 2009-01-11 9:49 (1 days old)
> > > References      : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> > > Handled-By      : Petr Titera <P.Titera@century.cz>
> > > Patch           : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> > 
> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP 
> > is defined.
> > 
> > I am still in the process of cleaning non-smp data from asm/smp.h for 
> > x86
> > 
> > Attach patch is the solution for the time being
> > 
> > Ingo, can you please put this in urgent queue.
> 
> yes, it already is - see below.

Link to this patch was added to the bug entry.  Pleaes let me know or close the
bug when it's merged.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jaswinder Singh - Jan. 13, 2009, 3:24 a.m.
Hello Rafael,

On Mon, Jan 12, 2009 at 12:30 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> On Sunday 11 January 2009, Ingo Molnar wrote:
>>
>> * Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
>>
>> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
>> > >
>> > > Regressions with patches
>> > > ------------------------
>> > >
>> > > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=12428
>> > > Subject         : Build error on latest git
>> > > Submitter       : Petr Titera <P.Titera@century.cz>
>> > > Date            : 2009-01-11 9:49 (1 days old)
>> > > References      : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
>> > > Handled-By      : Petr Titera <P.Titera@century.cz>
>> > > Patch           : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
>> >
>> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
>> > is defined.
>> >
>> > I am still in the process of cleaning non-smp data from asm/smp.h for
>> > x86
>> >
>> > Attach patch is the solution for the time being
>> >
>> > Ingo, can you please put this in urgent queue.
>>
>> yes, it already is - see below.
>
> Link to this patch was added to the bug entry.  Pleaes let me know or close the
> bug when it's merged.
>

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4884d8e6a05026ec906355436cea9dc1acb1d09e

--
JSR
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki - Jan. 13, 2009, 11:23 a.m.
On Tuesday 13 January 2009, Jaswinder Singh Rajput wrote:
> Hello Rafael,
> 
> On Mon, Jan 12, 2009 at 12:30 AM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Sunday 11 January 2009, Ingo Molnar wrote:
> >>
> >> * Jaswinder Singh Rajput <jaswinderlinux@gmail.com> wrote:
> >>
> >> > On Sun, Jan 11, 2009 at 4:42 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> >> > >
> >> > > Regressions with patches
> >> > > ------------------------
> >> > >
> >> > > Bug-Entry       : http://bugzilla.kernel.org/show_bug.cgi?id=12428
> >> > > Subject         : Build error on latest git
> >> > > Submitter       : Petr Titera <P.Titera@century.cz>
> >> > > Date            : 2009-01-11 9:49 (1 days old)
> >> > > References      : http://marc.info/?l=linux-kernel&m=123166856318712&w=4
> >> > > Handled-By      : Petr Titera <P.Titera@century.cz>
> >> > > Patch           : http://marc.info/?l=linux-kernel&m=123167509024996&w=4
> >> >
> >> > This is a wrong fix, asm/smp.h should only be included when CONFIG_SMP
> >> > is defined.
> >> >
> >> > I am still in the process of cleaning non-smp data from asm/smp.h for
> >> > x86
> >> >
> >> > Attach patch is the solution for the time being
> >> >
> >> > Ingo, can you please put this in urgent queue.
> >>
> >> yes, it already is - see below.
> >
> > Link to this patch was added to the bug entry.  Pleaes let me know or close the
> > bug when it's merged.
> >
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4884d8e6a05026ec906355436cea9dc1acb1d09e

Thanks, the bug has been closed.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/x86/kernel/mpparse.c b/arch/x86/kernel/mpparse.c
index c0601c2..a649a4c 100644
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -27,6 +27,7 @@ 
 #include <asm/e820.h>
 #include <asm/trampoline.h>
 #include <asm/setup.h>
+#include <asm/smp.h>
 
 #include <mach_apic.h>
 #ifdef CONFIG_X86_32