Patchwork [6/7] rs6000: Remove -mabi=ieeelongdouble.

login
register
mail settings
Submitter Segher Boessenkool
Date Aug. 16, 2012, 2:43 p.m.
Message ID <A0E3F767-55BC-45EA-BE88-38DC674B1014@kernel.crashing.org>
Download mbox | patch
Permalink /patch/178010/
State New
Headers show

Comments

Segher Boessenkool - Aug. 16, 2012, 2:43 p.m.
>> There are some problems with it:
>> - On at least 4.6 and later, it crashes the compiler together with  
>> -m64;
>> - On older versions, it generates incorrect code together with -m64;
>> - Supposedly it doesn't actually work on 32-bit either, on the  
>> glibc side;
>> - It isn't listed in --target-help, because the option file says
>>   "undocumented", but the manual does in fact list it;
>> - The Darwin header claims it is for POWER.
>>
>> In the spirit of the rest of this patch series, I solve these  
>> problems
>> by ripping it all out.
>
> As we discussed on IRC, this should work but is broken.  It should not
> be ripped out.

I figured as much :-)

> Would you please open a Bugzilla PR and include me, Meissner and Peter
> Bergner on the CC list?

Done, PR54284.

Also committed the attached as obvious, to fix the issue that made me
do this patch in the first place.

Cheers,


Segher


2012-08-16  Segher Boessenkool  <segher@kernel.crashing.org>

        * config/rs6000/darwin.h (TARGET_IEEE_QUAD): Fix comment.

Patch

--- gcc/config/rs6000/darwin.h  (revision 190445)
+++ gcc/config/rs6000/darwin.h  (working copy)
@@ -282,7 +282,7 @@ 
  #undef  TARGET_DEFAULT
  #define TARGET_DEFAULT (MASK_MULTIPLE | MASK_PPC_GFXOPT)

-/* Darwin only runs on PowerPC, so short-circuit POWER patterns.  */
+/* Darwin always uses IBM long double, never IEEE long double.  */
  #undef  TARGET_IEEEQUAD
  #define TARGET_IEEEQUAD 0