From patchwork Thu Aug 16 10:00:26 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Stornelli X-Patchwork-Id: 177939 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43ED12C0093 for ; Thu, 16 Aug 2012 20:07:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757067Ab2HPKG4 (ORCPT ); Thu, 16 Aug 2012 06:06:56 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:64266 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757061Ab2HPKGy (ORCPT ); Thu, 16 Aug 2012 06:06:54 -0400 Received: by wicr5 with SMTP id r5so519628wic.1 for ; Thu, 16 Aug 2012 03:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=FjVnLfXWakDvBRWGjp8Lu5Sk0RCYKfWgYfVb7bxDqZQ=; b=dRSVX+fmXQV51mCs8w8SFy0di+ztDzKSUAJNNbPRihQYzV7uHDFRclC2v7x0YQ4sdG 8OC4h4ia+JUqQfSjPdPiehkffsW7IoWPFgq2+wK++RVifMd8aj4xQBQywaDxROYQM3K/ 9dqlkW3XVUHqkIkBcutbwtID0RLRMBuUOB9k1f2wKNFwjLlWotokQEZMiYu1+imgCAM/ 1i4g/NzCdePgVzlq+EoHH3IPYtTphuSWjx/cZg7ZfGm53lW7uWgmH78su5llQ5/7ySVO 3yNZjx3IWjNf7I1mGVNc+4moRAoSLzuWUDOpC+URTGPecZf2cYKhxaMd4hq903lH2wga ZJew== Received: by 10.180.82.164 with SMTP id j4mr1799678wiy.18.1345111612827; Thu, 16 Aug 2012 03:06:52 -0700 (PDT) Received: from [80.183.114.242] (host242-114-dynamic.183-80-r.retail.telecomitalia.it. [80.183.114.242]) by mx.google.com with ESMTPS id bc2sm4642430wib.0.2012.08.16.03.06.49 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 16 Aug 2012 03:06:52 -0700 (PDT) Message-ID: <502CC4BA.3040702@gmail.com> Date: Thu, 16 Aug 2012 12:00:26 +0200 From: Marco Stornelli User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120601 Thunderbird/13.0 MIME-Version: 1.0 To: bharrosh@panasas.com, bhalevy@tonian.com, jack@suse.cz, Andrew Morton , adilger.kernel@dilger.ca, tytso@mit.edu, hirofumi@mail.parknet.co.jp, mikulas@artax.karlin.mff.cuni.cz, Al Viro , hch@infradead.org, dushistov@mail.ru, osd-dev@open-osd.org, Linux Kernel , linux-ext4@vger.kernel.org, Linux FS Devel Subject: [PATCH 3/8] ext3: remove lock/unlock super Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Marco Stornelli Replaced lock and unlock super with a new fs mutex s_lock. Signed-off-by: Marco Stornelli --- static int ext3_unfreeze(struct super_block *sb) { if (!(sb->s_flags & MS_RDONLY)) { - lock_super(sb); + mutex_lock(&EXT3_SB(sb)->s_lock); /* Reser the needs_recovery flag before the fs is unlocked. */ EXT3_SET_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); ext3_commit_super(sb, EXT3_SB(sb)->s_es, 1); - unlock_super(sb); + mutex_unlock(&EXT3_SB(sb)->s_lock); journal_unlock_updates(EXT3_SB(sb)->s_journal); } return 0; @@ -2606,7 +2607,7 @@ static int ext3_remount (struct super_bl #endif /* Store the original options */ - lock_super(sb); + mutex_lock(&EXT3_SB(sb)->s_lock); old_sb_flags = sb->s_flags; old_opts.s_mount_opt = sbi->s_mount_opt; old_opts.s_resuid = sbi->s_resuid; @@ -2712,7 +2713,7 @@ static int ext3_remount (struct super_bl old_opts.s_qf_names[i] != sbi->s_qf_names[i]) kfree(old_opts.s_qf_names[i]); #endif - unlock_super(sb); + mutex_unlock(&EXT3_SB(sb)->s_lock); if (enable_quota) dquot_resume(sb, -1); @@ -2732,7 +2733,7 @@ restore_opts: sbi->s_qf_names[i] = old_opts.s_qf_names[i]; } #endif - unlock_super(sb); + mutex_unlock(&EXT3_SB(sb)->s_lock); return err; } -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -Nurp linux-3.6-rc1-orig/fs/ext3/ext3.h linux-3.6-rc1/fs/ext3/ext3.h --- linux-3.6-rc1-orig/fs/ext3/ext3.h 2012-08-16 09:37:31.000000000 +0200 +++ linux-3.6-rc1/fs/ext3/ext3.h 2012-08-16 09:46:39.000000000 +0200 @@ -672,6 +672,7 @@ struct ext3_sb_info { char *s_qf_names[MAXQUOTAS]; /* Names of quota files with journalled quota */ int s_jquota_fmt; /* Format of quota to use */ #endif + struct mutex s_lock; }; static inline spinlock_t * diff -Nurp linux-3.6-rc1-orig/fs/ext3/super.c linux-3.6-rc1/fs/ext3/super.c --- linux-3.6-rc1-orig/fs/ext3/super.c 2012-08-16 09:37:31.000000000 +0200 +++ linux-3.6-rc1/fs/ext3/super.c 2012-08-16 09:49:11.000000000 +0200 @@ -1939,6 +1939,7 @@ static int ext3_fill_super (struct super sbi->s_gdb_count = db_count; get_random_bytes(&sbi->s_next_generation, sizeof(u32)); spin_lock_init(&sbi->s_next_gen_lock); + mutex_init(&sbi->s_lock); /* per fileystem reservation list head & lock */ spin_lock_init(&sbi->s_rsv_window_lock); @@ -2582,11 +2583,11 @@ out: