Test 272 fails for ext3

Submitted by Jan Kara on Aug. 16, 2012, 9:37 a.m.

Details

Message ID 20120816093757.GA11519@quack.suse.cz
State Not Applicable, archived
Headers show

Commit Message

Jan Kara Aug. 16, 2012, 9:37 a.m.
Hello,

  I was looking into why test 272 from xfstests fails for ext3 and the
reason is that ext3 does not support direct IO to file with enabled data
journalling (open returns EINVAL because ->direct_IO callback is not
specified). So I was thinking how to accomodate this fact in the test -
the best I found was to just check using xfs_io whether O_DIRECT open
succeeds and perform the test only in that case. Attached patch does this
or do people have other ideas?

								Honza

PS: Sending again with correct list address. I'm sorry for unnecessary email.

Comments

Dmitri Monakho Aug. 16, 2012, 10:07 a.m.
On Thu, 16 Aug 2012 11:37:57 +0200, Jan Kara <jack@suse.cz> wrote:
Non-text part: multipart/mixed
>   Hello,
> 
>   I was looking into why test 272 from xfstests fails for ext3 and the
> reason is that ext3 does not support direct IO to file with enabled data
> journalling (open returns EINVAL because ->direct_IO callback is not
> specified). So I was thinking how to accomodate this fact in the test -
> the best I found was to just check using xfs_io whether O_DIRECT open
> succeeds and perform the test only in that case. Attached patch does this
> or do people have other ideas?
Looks reasonable
ACK.
> 
> 								Honza
> 
> PS: Sending again with correct list address. I'm sorry for unnecessary email.
> -- 
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
> From 529429c8497314ef956e470fdb9b94bfe797df69 Mon Sep 17 00:00:00 2001
> From: Jan Kara <jack@suse.cz>
> Date: Thu, 16 Aug 2012 11:14:35 +0200
> Subject: [PATCH] Make test 272 work for ext3
> 
> ext3 does not support direct IO for files with data journalling. This
> confuses test 272. Make the test check whether open succeeds and perform
> the writing only if it does.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  272 |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/272 b/272
> index 26dfa3b..e39c52b 100755
> --- a/272
> +++ b/272
> @@ -52,6 +52,12 @@ _workout()
>  		    
>  			echo "OP write_opt: $write_opt 4M, \
>  chattr_opt: $chattr_opt"
> +			if [ "$write_opt" = "oflag=direct" ]; then
> +				# Some filesystems don't support direct IO
> +				# in some cases, check for that
> +				xfs_io -F -d -f -c "" $SCRATCH_MNT/file.$idx \
> +					>> $seq.full 2>&1 || continue
> +			fi
>  			dd if=/dev/zero of=$SCRATCH_MNT/file.$idx \
>  				bs=1M count=4 $write_opt \
>  				>> $seq.full 2>&1 || exit
> -- 
> 1.7.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dave Chinner Aug. 16, 2012, 10:48 p.m.
On Thu, Aug 16, 2012 at 11:37:57AM +0200, Jan Kara wrote:
>   Hello,
> 
>   I was looking into why test 272 from xfstests fails for ext3 and the
> reason is that ext3 does not support direct IO to file with enabled data
> journalling (open returns EINVAL because ->direct_IO callback is not
> specified). So I was thinking how to accomodate this fact in the test -
> the best I found was to just check using xfs_io whether O_DIRECT open
> succeeds and perform the test only in that case. Attached patch does this
> or do people have other ideas?


# ext3 doesn't support direct IO in journalling mode
ext3_write_opt_list="iflag=noatime conv=notrunc conv=fsync"
ext4_write_opt_list="iflag=noatime conv=notrunc conv=fsync oflag=direct"

if [ $FSTYP = "ext3" ]; then
	write_opt_list="$ext3_write_opt_list"
else
	write_opt_list="$ext4_write_opt_list"
fi

.....
> diff --git a/272 b/272
> index 26dfa3b..e39c52b 100755
> --- a/272
> +++ b/272
> @@ -52,6 +52,12 @@ _workout()
>  		    
>  			echo "OP write_opt: $write_opt 4M, \
>  chattr_opt: $chattr_opt"
> +			if [ "$write_opt" = "oflag=direct" ]; then
> +				# Some filesystems don't support direct IO
> +				# in some cases, check for that
> +				xfs_io -F -d -f -c "" $SCRATCH_MNT/file.$idx \
> +					>> $seq.full 2>&1 || continue
> +			fi

That only fixes one of the two places that does direct IO on a
jounralled file. The above will fix both...

Cheers,

Dave.

Patch hide | download patch | download mbox

From 529429c8497314ef956e470fdb9b94bfe797df69 Mon Sep 17 00:00:00 2001
From: Jan Kara <jack@suse.cz>
Date: Thu, 16 Aug 2012 11:14:35 +0200
Subject: [PATCH] Make test 272 work for ext3

ext3 does not support direct IO for files with data journalling. This
confuses test 272. Make the test check whether open succeeds and perform
the writing only if it does.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 272 |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/272 b/272
index 26dfa3b..e39c52b 100755
--- a/272
+++ b/272
@@ -52,6 +52,12 @@  _workout()
 		    
 			echo "OP write_opt: $write_opt 4M, \
 chattr_opt: $chattr_opt"
+			if [ "$write_opt" = "oflag=direct" ]; then
+				# Some filesystems don't support direct IO
+				# in some cases, check for that
+				xfs_io -F -d -f -c "" $SCRATCH_MNT/file.$idx \
+					>> $seq.full 2>&1 || continue
+			fi
 			dd if=/dev/zero of=$SCRATCH_MNT/file.$idx \
 				bs=1M count=4 $write_opt \
 				>> $seq.full 2>&1 || exit
-- 
1.7.1