Patchwork dma: amba-pl08x: Export pl08x_filter_id

login
register
mail settings
Submitter stigge@antcom.de
Date Aug. 16, 2012, 8:56 a.m.
Message ID <1345107396-27079-1-git-send-email-stigge@antcom.de>
Download mbox | patch
Permalink /patch/177923/
State New
Headers show

Comments

stigge@antcom.de - Aug. 16, 2012, 8:56 a.m.
This patch fixes the following when compiling a driver module that uses
amba-pl08x:

ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!

(drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

Done as in:

drivers/dma/coh901318.c
drivers/dma/sirf-dma.c

Signed-off-by: Roland Stigge <stigge@antcom.de>
Arnd Bergmann - Aug. 16, 2012, 8:59 a.m.
On Thursday 16 August 2012, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> Done as in:
> 
> drivers/dma/coh901318.c
> drivers/dma/sirf-dma.c
> 
> Signed-off-by: Roland Stigge <stigge@antcom.de>

Acked-by: Arnd Bergmann <arnd@arndb.de>
Russell King - ARM Linux - Aug. 16, 2012, 9 a.m.
On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> This patch fixes the following when compiling a driver module that uses
> amba-pl08x:
> 
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> 
> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)

It is currently intended that this be passed from platform code into
drivers via platform data, so that drivers can decide which DMA engine
they wish to make use of.

See how all the AMBA drivers work in this regard (because they need to
support more than just a single DMA engine implementation.)
Arnd Bergmann - Aug. 16, 2012, 9:06 a.m.
On Thursday 16 August 2012, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
> > This patch fixes the following when compiling a driver module that uses
> > amba-pl08x:
> > 
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
> > ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
> > 
> > (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Ah, you're right, I forgot about that. I'll take back my Ack then.

	Arnd
stigge@antcom.de - Aug. 16, 2012, 1:13 p.m.
On 08/16/2012 11:00 AM, Russell King - ARM Linux wrote:
> On Thu, Aug 16, 2012 at 10:56:36AM +0200, Roland Stigge wrote:
>> This patch fixes the following when compiling a driver module that uses
>> amba-pl08x:
>>
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_slc.ko] undefined!
>> ERROR: "pl08x_filter_id" [drivers/mtd/nand/lpc32xx_mlc.ko] undefined!
>>
>> (drivers/mtd/nand/lpc32xx_* are still in l2-mtd.git)
> 
> It is currently intended that this be passed from platform code into
> drivers via platform data, so that drivers can decide which DMA engine
> they wish to make use of.
> 
> See how all the AMBA drivers work in this regard (because they need to
> support more than just a single DMA engine implementation.)

Thanks for the note!

I'll post respective changes to the MTD SLC and MLC drivers of LPC32xx
(for the MTD subsystem) and the adjustment I'll do in mach-lpc32xx (my
lpc32xx tree for arm-soc).

Patch

diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 6fbeebb..8c2e9b6 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -1608,6 +1608,7 @@  bool pl08x_filter_id(struct dma_chan *chan, void *chan_id)
 
 	return false;
 }
+EXPORT_SYMBOL(pl08x_filter_id);
 
 /*
  * Just check that the device is there and active