From patchwork Sun Jan 11 07:44:53 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: sparc32 broke From: David Miller X-Patchwork-Id: 17783 X-Patchwork-Delegate: davem@davemloft.net Message-Id: <20090110.234453.254713982.davem@davemloft.net> To: reif@earthlink.net Cc: sam@ravnborg.org, sparclinux@vger.kernel.org Date: Sat, 10 Jan 2009 23:44:53 -0800 (PST) From: Robert Reif Date: Sat, 10 Jan 2009 09:56:01 -0500 > David Miller wrote: > > From: Sam Ravnborg > > Date: Sat, 10 Jan 2009 08:33:21 +0100 > > > > > >> The real fix should look like this: > >> > >> #ifdef __arch64__ > >> #define _NSIG_BPW 64 > >> #else > >> #define _NSIG_BPW 64 > >> #endif > >> > >> This is required because this header is exported to userspace > >> where we do not have access to CONFIG_* symbols. > >> > > > > I assume you meant to use "32" in the #else branch :-) > > This fixed it (with the 32). Thanks for testing Robert, I've just commited the following: sparc: Fix asm/signal.h for 32-bit. Fix a 32-bit sparc regression reported by Robert Reif. _NSIG_BPW needs to be 32 for 32-bit and 64 for 64-bit Tested-by: Robert Reif Signed-off-by: David S. Miller --- arch/sparc/include/asm/signal.h | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/arch/sparc/include/asm/signal.h b/arch/sparc/include/asm/signal.h index 41535e7..cba4520 100644 --- a/arch/sparc/include/asm/signal.h +++ b/arch/sparc/include/asm/signal.h @@ -84,7 +84,11 @@ #define __OLD_NSIG 32 #define __NEW_NSIG 64 +#ifdef __arch64__ #define _NSIG_BPW 64 +#else +#define _NSIG_BPW 32 +#endif #define _NSIG_WORDS (__NEW_NSIG / _NSIG_BPW) #define SIGRTMIN 32