Patchwork PR target/53633; disable return value warnings for naked functions

login
register
mail settings
Submitter H.J. Lu
Date Aug. 15, 2012, 4:54 p.m.
Message ID <CAMe9rOoLninPov_H6VsJaCaF_A7W+gCXmObq0YmTp88S0Mn8kQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/177734/
State New
Headers show

Comments

H.J. Lu - Aug. 15, 2012, 4:54 p.m.
On Wed, Jul 25, 2012 at 11:11 AM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 07/25/2012 09:57 AM, Richard Henderson wrote:
>>
>> I'll echo Nick's comments about arm asm in a common test.
>> There's no need to have anything but __asm__(""); there.
>>
>> Ok with that change.
>
> Thanks!  Here's the version I committed.
>
> -Sandra
>
>
> 2012-07-25  Sandra Loosemore  <sandra@codesourcery.com>
>             Paul Brook  <paul@codesourcery.com>
>
>         PR target/53633
>
>         gcc/
>         * target.def (warn_func_return): New hook.
>         * doc/tm.texi.in (TARGET_WARN_FUNC_RETURN): New hook.
>         * doc/tm.texi: Regenerate.
>         * doc/sourcebuild.texi (Effective-Target Keywords): Document
>         naked_functions.
>         * ipa-pure-const.c (warn_function_noreturn): Check
>         targetm.warn_func_return.
>         * tree-cfg.c (execute_warn_function_return): Likewise.

You didn't mention that you included "target.h" nor add "target.h"
dependency on tree-cfg.c.  I am checking in this as an obvious fix.

Patch

diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 65a49d7..f2366ad 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2363,7 +2363,7 @@  tree-vrp.o : tree-vrp.c $(CONFIG_H) $(SYSTEM_H)
coretypes.h $(TM_H) $(TREE_H) \
    $(CFGLOOP_H) $(SCEV_H) intl.h \
    $(GIMPLE_PRETTY_PRINT_H) gimple-fold.h $(OPTABS_H) $(EXPR_H)
 tree-cfg.o : tree-cfg.c $(TREE_FLOW_H) $(CONFIG_H) $(SYSTEM_H) \
-   $(TREE_H) $(TM_P_H) $(GGC_H) $(FLAGS_H) \
+   $(TREE_H) $(TM_P_H) $(GGC_H) $(FLAGS_H) $(TARGET_H) \
    $(DIAGNOSTIC_CORE_H) $(FUNCTION_H) $(TM_H) coretypes.h \
    $(TREE_DUMP_H) $(EXCEPT_H) $(CFGLOOP_H) $(TREE_PASS_H) \