| Message ID | 1345042466-31743-2-git-send-email-benoit@irqsave.net |
|---|---|
| State | New |
| Headers | show |
On Wed, 15 Aug 2012 16:54:24 +0200 "Benoît Canet" <benoit.canet@gmail.com> wrote: > Signed-off-by: Benoit Canet <benoit@irqsave.net> > --- > qapi-schema.json | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index a92adb1..8d4df19 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -126,6 +126,30 @@ > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } > > ## > +# @SnapshotInfo > +# > +# @id: unique snapshot id > +# > +# @name: user choosen name > +# > +# @vm-state-size: size of the VM state > +# > +# @date-sec: UTC date of the snapshot > +# > +# @date-nsec: date in nano seconds > +# > +# @vm-clock-sec: VM clock relative to boot > +# > +# Since: 1.3 > +# > +## > + > +{ 'type': 'SnapshotInfo', > + 'data': { 'id': 'str', 'name': 'str', 'vm-state-size': 'int', > + 'date-sec': 'int', 'date-nsec': 'int', > + 'vm-clock-sec': 'int' } } Can I assume that this matches with what should be returned by the (hopefully not so distant) future query-snapshots command? > + > +## > # @StatusInfo: > # > # Information about VCPU run state
On 08/15/2012 08:54 AM, Benoît Canet wrote: > Signed-off-by: Benoit Canet <benoit@irqsave.net> > --- > qapi-schema.json | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/qapi-schema.json b/qapi-schema.json > index a92adb1..8d4df19 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -126,6 +126,30 @@ > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } > > ## > +# @SnapshotInfo > +# > +# @id: unique snapshot id > +# > +# @name: user choosen name > +# > +# @vm-state-size: size of the VM state > +# > +# @date-sec: UTC date of the snapshot > +# > +# @date-nsec: date in nano seconds How come we track a subsecond creation time, > +# > +# @vm-clock-sec: VM clock relative to boot but not a subsecond relative time for the VM clock? Is that additional precision available for querying? I have no problem if you want to squash patches 1 and 2 together into a single commit.
Le Wednesday 15 Aug 2012 à 12:04:56 (-0600), Eric Blake a écrit : > On 08/15/2012 08:54 AM, Benoît Canet wrote: > > Signed-off-by: Benoit Canet <benoit@irqsave.net> > > --- > > qapi-schema.json | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/qapi-schema.json b/qapi-schema.json > > index a92adb1..8d4df19 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -126,6 +126,30 @@ > > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } > > > > ## > > +# @SnapshotInfo > > +# > > +# @id: unique snapshot id > > +# > > +# @name: user choosen name > > +# > > +# @vm-state-size: size of the VM state > > +# > > +# @date-sec: UTC date of the snapshot > > +# > > +# @date-nsec: date in nano seconds > I took all the availables fields: typedef struct QEMUSnapshotInfo { char id_str[128]; /* unique snapshot id */ /* the following fields are informative. They are not needed for the consistency of the snapshot */ char name[256]; /* user chosen name */ uint64_t vm_state_size; /* VM state info size */ uint32_t date_sec; /* UTC date of the snapshot */ uint32_t date_nsec; uint64_t vm_clock_nsec; /* VM clock relative to boot */ } QEMUSnapshotInfo; > How come we track a subsecond creation time, > > > +# > > +# @vm-clock-sec: VM clock relative to boot > > but not a subsecond relative time for the VM clock? Is that additional > precision available for querying? This one is vm-clock-nsec I made a typo > > I have no problem if you want to squash patches 1 and 2 together into a > single commit. ok Benoît > > -- > Eric Blake eblake@redhat.com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >
Le Wednesday 15 Aug 2012 à 14:58:45 (-0300), Luiz Capitulino a écrit : > On Wed, 15 Aug 2012 16:54:24 +0200 > "Benoît Canet" <benoit.canet@gmail.com> wrote: > > > Signed-off-by: Benoit Canet <benoit@irqsave.net> > > --- > > qapi-schema.json | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/qapi-schema.json b/qapi-schema.json > > index a92adb1..8d4df19 100644 > > --- a/qapi-schema.json > > +++ b/qapi-schema.json > > @@ -126,6 +126,30 @@ > > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } > > > > ## > > +# @SnapshotInfo > > +# > > +# @id: unique snapshot id > > +# > > +# @name: user choosen name > > +# > > +# @vm-state-size: size of the VM state > > +# > > +# @date-sec: UTC date of the snapshot > > +# > > +# @date-nsec: date in nano seconds > > +# > > +# @vm-clock-sec: VM clock relative to boot > > +# > > +# Since: 1.3 > > +# > > +## > > + > > +{ 'type': 'SnapshotInfo', > > + 'data': { 'id': 'str', 'name': 'str', 'vm-state-size': 'int', > > + 'date-sec': 'int', 'date-nsec': 'int', > > + 'vm-clock-sec': 'int' } } > > Can I assume that this matches with what should be returned by the (hopefully > not so distant) future query-snapshots command? These are the field of the struture in block.h. yet I don't know if it answer correctly to the question :) > > > + > > +## > > # @StatusInfo: > > # > > # Information about VCPU run state > >
diff --git a/qapi-schema.json b/qapi-schema.json index a92adb1..8d4df19 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -126,6 +126,30 @@ 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] } ## +# @SnapshotInfo +# +# @id: unique snapshot id +# +# @name: user choosen name +# +# @vm-state-size: size of the VM state +# +# @date-sec: UTC date of the snapshot +# +# @date-nsec: date in nano seconds +# +# @vm-clock-sec: VM clock relative to boot +# +# Since: 1.3 +# +## + +{ 'type': 'SnapshotInfo', + 'data': { 'id': 'str', 'name': 'str', 'vm-state-size': 'int', + 'date-sec': 'int', 'date-nsec': 'int', + 'vm-clock-sec': 'int' } } + +## # @StatusInfo: # # Information about VCPU run state
Signed-off-by: Benoit Canet <benoit@irqsave.net> --- qapi-schema.json | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)