Patchwork [7/7] ppc/pseries: Reset VPA registration on CPU reset

login
register
mail settings
Submitter David Gibson
Date Aug. 15, 2012, 4:33 a.m.
Message ID <1345005228-4380-8-git-send-email-david@gibson.dropbear.id.au>
Download mbox | patch
Permalink /patch/177542/
State New
Headers show

Comments

David Gibson - Aug. 15, 2012, 4:33 a.m.
The ppc specific CPU state contains several variables which track the
VPA, SLB shadow and dispatch trace log.  These are structures shared
between OS and hypervisor that are used on the pseries machine to track
various per-CPU quantities.

The address of these structures needs to be registered by the guest on each
boot, however currently this registration is not cleared when we reset the
cpu.  This patch corrects this bug.  Well, it corrects it for the full emu
case anyway.  To fix the KVM case, we need some KVM extensions to actually
make the KVM internal VPA registration accessible to qemu.  Patches coming
for qemu once the kernel updates are merged.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 target-ppc/translate_init.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Patch

diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index 6fe4168..2bc4a3f 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -10423,6 +10423,14 @@  static void ppc_cpu_reset(CPUState *s)
     env->pending_interrupts = 0;
     env->exception_index = POWERPC_EXCP_NONE;
     env->error_code = 0;
+
+#if defined(TARGET_PPC64) && !defined(CONFIG_USER_ONLY)
+    env->vpa = 0;
+    env->slb_shadow = 0;
+    env->dispatch_trace_log = 0;
+    env->dtl_size = 0;
+#endif /* TARGET_PPC64 */
+
     /* Flush all TLBs */
     tlb_flush(env, 1);
 }