From patchwork Tue Aug 14 23:52:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 177517 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from mail-ob0-f184.google.com (mail-ob0-f184.google.com [209.85.214.184]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority" (not verified)) by ozlabs.org (Postfix) with ESMTPS id 7C2BC2C0081 for ; Wed, 15 Aug 2012 09:52:15 +1000 (EST) Received: by obbwc20 with SMTP id wc20sf960391obb.11 for ; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=beta; h=x-beenthere:received-spf:date:from:to:cc:subject:message-id :in-reply-to:references:x-mailer:mime-version:x-original-sender :x-original-authentication-results:reply-to:precedence:mailing-list :list-id:x-google-group-id:list-post:list-help:list-archive:sender :list-subscribe:list-unsubscribe:content-type; bh=HRUwrifpspwrPk9NWOh2SBF9T47lD7E6yuKAqsJ6a+0=; b=PvJueKk0SJv+Ueh91hn0HtAsfsT36NyNfHM4I5GyO03goTCzCc7nmJzFGAepv0Pl6F GJE6BQa2U/2/lY46EN8Qobtde4OwfSzmmxFd3MmBJy+sVwxYsihfjKU2JSxY0A6b6PGB MJGPG0UQH7Log45l1+0ONAIm0VtR4sVxF/Tjw= Received: by 10.68.136.7 with SMTP id pw7mr2290290pbb.1.1344988333558; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) X-BeenThere: rtc-linux@googlegroups.com Received: by 10.68.201.168 with SMTP id kb8ls1995175pbc.2.gmail; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) Received: by 10.66.85.8 with SMTP id d8mr2422982paz.40.1344988333124; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) Received: by 10.66.85.8 with SMTP id d8mr2422981paz.40.1344988333113; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by gmr-mx.google.com with ESMTP id p7si63654pby.0.2012.08.14.16.52.13; Tue, 14 Aug 2012 16:52:13 -0700 (PDT) Received-SPF: pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) client-ip=140.211.169.12; Received: from akpm.mtv.corp.google.com (216-239-45-4.google.com [216.239.45.4]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 9190C308; Tue, 14 Aug 2012 23:52:12 +0000 (UTC) Date: Tue, 14 Aug 2012 16:52:11 -0700 From: Andrew Morton To: Venu Byravarasu Cc: , , , , , , Subject: [rtc-linux] Re: [PATCH] rtc: tps65910: Add RTC driver for TPS65910 PMIC RTC Message-Id: <20120814165211.daf24c81.akpm@linux-foundation.org> In-Reply-To: <1343284519-30505-1-git-send-email-vbyravarasu@nvidia.com> References: <1343284519-30505-1-git-send-email-vbyravarasu@nvidia.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Original-Sender: akpm@linux-foundation.org X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of akpm@linux-foundation.org designates 140.211.169.12 as permitted sender) smtp.mail=akpm@linux-foundation.org Reply-To: rtc-linux@googlegroups.com Precedence: list Mailing-list: list rtc-linux@googlegroups.com; contact rtc-linux+owners@googlegroups.com List-ID: X-Google-Group-Id: 712029733259 List-Post: , List-Help: , List-Archive: Sender: rtc-linux@googlegroups.com List-Subscribe: , List-Unsubscribe: , On Thu, 26 Jul 2012 12:05:19 +0530 Venu Byravarasu wrote: > TPS65910 PMIC is a MFD with RTC as one of the device. > Adding RTC driver for supporting RTC device present > inside TPS65910 PMIC. > > Only support for RTC alarm is implemented as part of this patch. It needs a build fix: drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_suspend': drivers/rtc/rtc-tps65910.c:313: error: request for member 'irqstat' in something not a structure or union drivers/rtc/rtc-tps65910.c: In function 'tps65910_rtc_resume': drivers/rtc/rtc-tps65910.c:327: error: request for member 'irqstat' in something not a structure or union but it still has problems: drivers/rtc/rtc-tps65910.c:331: warning: initialization from incompatible pointer type drivers/rtc/rtc-tps65910.c:332: warning: initialization from incompatible pointer type fix and resend, please? --- a/drivers/rtc/rtc-tps65910.c~rtc-tps65910-add-rtc-driver-for-tps65910-pmic-rtc-fix +++ a/drivers/rtc/rtc-tps65910.c @@ -310,7 +310,7 @@ static int tps65910_rtc_suspend(struct p /* Store current list of enabled interrupts*/ ret = regmap_read(tps->regmap, TPS65910_RTC_INTERRUPTS, - &tps->rtc.irqstat); + &tps->rtc->irqstat); if (ret < 0) return ret; @@ -324,7 +324,7 @@ static int tps65910_rtc_resume(struct pl /* Restore list of enabled interrupts before suspend */ return regmap_write(tps->regmap, TPS65910_RTC_INTERRUPTS, - tps->rtc.irqstat); + tps->rtc->irqstat); } static const struct dev_pm_ops tps65910_rtc_pm_ops = {