From patchwork Tue Aug 14 22:34:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Fastabend X-Patchwork-Id: 177468 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 0BEFA2C0086 for ; Wed, 15 Aug 2012 08:51:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753321Ab2HNWu3 (ORCPT ); Tue, 14 Aug 2012 18:50:29 -0400 Received: from mga02.intel.com ([134.134.136.20]:7736 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751863Ab2HNWu1 (ORCPT ); Tue, 14 Aug 2012 18:50:27 -0400 Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 14 Aug 2012 15:50:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.77,769,1336374000"; d="scan'208";a="180764173" Received: from unknown (HELO [127.0.0.1]) ([10.23.155.170]) by orsmga001.jf.intel.com with ESMTP; 14 Aug 2012 15:50:26 -0700 From: John Fastabend Subject: [net PATCH v3 2/3] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly To: viro@ZenIV.linux.org.uk, nhorman@tuxdriver.com Cc: netdev@vger.kernel.org, davem@davemloft.net, linux-kernel@vger.kernel.org, joe@perches.com Date: Tue, 14 Aug 2012 15:34:30 -0700 Message-ID: <20120814223430.3551.88909.stgit@jf-dev1-dcblab> In-Reply-To: <20120814223424.3551.21608.stgit@jf-dev1-dcblab> References: <20120814223424.3551.21608.stgit@jf-dev1-dcblab> User-Agent: StGIT/0.14.3 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org A socket fd passed in a SCM_RIGHTS datagram was not getting updated with the new tasks cgrp prioidx. This leaves IO on the socket tagged with the old tasks priority. To fix this add a check in the scm recvmsg path to update the sock cgrp prioidx with the new tasks value. Thanks to Al Viro for catching this. CC: Neil Horman Reported-by: Al Viro Signed-off-by: John Fastabend Acked-by: Neil Horman --- net/core/scm.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/core/scm.c b/net/core/scm.c index 8f6ccfd..040cebe 100644 --- a/net/core/scm.c +++ b/net/core/scm.c @@ -265,6 +265,7 @@ void scm_detach_fds(struct msghdr *msg, struct scm_cookie *scm) for (i=0, cmfptr=(__force int __user *)CMSG_DATA(cm); isk, current); fd_install(new_fd, fp[i]); }