From patchwork Tue Aug 14 22:10:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [1/1] ppc: e500_tlb memset clears nothing Date: Tue, 14 Aug 2012 12:10:09 -0000 From: Andrew Morton X-Patchwork-Id: 177466 Message-Id: <20120814221010.7EC405C0065@hpza9.eem.corp.google.com> To: benh@kernel.crashing.org Cc: agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, akpm@linux-foundation.org, alan@linux.intel.com, avi@redhat.com, dcb314@hotmail.com, mtosatti@redhat.com, paulus@samba.org From: Alan Cox Subject: ppc: e500_tlb memset clears nothing Put the parameters the right way around Addresses https://bugzilla.kernel.org/show_bug.cgi?id=44031 Reported-by: David Binderman Signed-off-by: Alan Cox Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Alexander Graf Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Signed-off-by: Andrew Morton --- arch/powerpc/kvm/e500_tlb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing arch/powerpc/kvm/e500_tlb.c --- a/arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing +++ a/arch/powerpc/kvm/e500_tlb.c @@ -320,11 +320,11 @@ static inline void kvmppc_e500_ref_relea static void clear_tlb1_bitmap(struct kvmppc_vcpu_e500 *vcpu_e500) { if (vcpu_e500->g2h_tlb1_map) - memset(vcpu_e500->g2h_tlb1_map, - sizeof(u64) * vcpu_e500->gtlb_params[1].entries, 0); + memset(vcpu_e500->g2h_tlb1_map, 0, + sizeof(u64) * vcpu_e500->gtlb_params[1].entries); if (vcpu_e500->h2g_tlb1_rmap) - memset(vcpu_e500->h2g_tlb1_rmap, - sizeof(unsigned int) * host_tlb_params[1].entries, 0); + memset(vcpu_e500->h2g_tlb1_rmap, 0, + sizeof(unsigned int) * host_tlb_params[1].entries); } static void clear_tlb_privs(struct kvmppc_vcpu_e500 *vcpu_e500)