From patchwork Tue Aug 14 22:10:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 177466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DFDCC2C008D for ; Wed, 15 Aug 2012 08:10:16 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751223Ab2HNWKP (ORCPT ); Tue, 14 Aug 2012 18:10:15 -0400 Received: from mail-wi0-f202.google.com ([209.85.212.202]:61626 "EHLO mail-wi0-f202.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818Ab2HNWKO (ORCPT ); Tue, 14 Aug 2012 18:10:14 -0400 Received: by wibhr14 with SMTP id hr14so44562wib.1 for ; Tue, 14 Aug 2012 15:10:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=subject:to:cc:from:date:mime-version:content-type :content-transfer-encoding:message-id:x-gm-message-state; bh=VWV7iyi0fg2BQPb0EfIanOl8d3gNwewB3zGTELJ0lbI=; b=cd18YqZc8qodqczNlRf3IIFTsdP2E8GEf1wnv6C38BBwl3rY/EDn4F6yj/rbuEM7aW OYXQZW0Et675PbZ3KauWmo7wpS9yH8Txul5ffGv1hg1nqFW3zLe/qfJS0E9KxFlZuQIB t50Fhcq9S+dwrKkKxCLGrrKiEjbB4Xs1DCdpdQF72kDPFdd8lfHxY6oSMFu8IvfJPIs/ ybHG6mGCDnIyLyMtNWi51804yiGzJA0CQafjNvgrFoy+PYnh2+dFHZ3SLyRxZZZk1ShM jEbhWW5nYpAGxbTiWnN913E9foEuNCr9aBa1MLlVzfxB2k0Z8zxik1yol/lxQCPcrtiF o1Pg== Received: by 10.14.220.131 with SMTP id o3mr8211837eep.6.1344982212470; Tue, 14 Aug 2012 15:10:12 -0700 (PDT) Received: from hpza9.eem.corp.google.com ([74.125.121.33]) by gmr-mx.google.com with ESMTPS id 46si4908476eed.1.2012.08.14.15.10.12 (version=TLSv1/SSLv3 cipher=AES128-SHA); Tue, 14 Aug 2012 15:10:12 -0700 (PDT) Received: from localhost.localdomain (akpm.mtv.corp.google.com [172.18.96.75]) by hpza9.eem.corp.google.com (Postfix) with ESMTP id 7EC405C0065; Tue, 14 Aug 2012 15:10:10 -0700 (PDT) Subject: [patch 1/1] ppc: e500_tlb memset clears nothing To: benh@kernel.crashing.org Cc: agraf@suse.de, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, akpm@linux-foundation.org, alan@linux.intel.com, avi@redhat.com, dcb314@hotmail.com, mtosatti@redhat.com, paulus@samba.org From: akpm@linux-foundation.org Date: Tue, 14 Aug 2012 15:10:09 -0700 MIME-Version: 1.0 Message-Id: <20120814221010.7EC405C0065@hpza9.eem.corp.google.com> X-Gm-Message-State: ALoCoQkqgMxKLys093by7+d/cjBIpLf3RTvHdcws/Gbm7kYtz8oMbYoMaiZK2+DrTBZTJAdJgEXP Sender: kvm-ppc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm-ppc@vger.kernel.org From: Alan Cox Subject: ppc: e500_tlb memset clears nothing Put the parameters the right way around Addresses https://bugzilla.kernel.org/show_bug.cgi?id=44031 Reported-by: David Binderman Signed-off-by: Alan Cox Cc: Avi Kivity Cc: Marcelo Tosatti Cc: Alexander Graf Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Signed-off-by: Andrew Morton --- arch/powerpc/kvm/e500_tlb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff -puN arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing arch/powerpc/kvm/e500_tlb.c --- a/arch/powerpc/kvm/e500_tlb.c~ppc-e500_tlb-memset-clears-nothing +++ a/arch/powerpc/kvm/e500_tlb.c @@ -320,11 +320,11 @@ static inline void kvmppc_e500_ref_relea static void clear_tlb1_bitmap(struct kvmppc_vcpu_e500 *vcpu_e500) { if (vcpu_e500->g2h_tlb1_map) - memset(vcpu_e500->g2h_tlb1_map, - sizeof(u64) * vcpu_e500->gtlb_params[1].entries, 0); + memset(vcpu_e500->g2h_tlb1_map, 0, + sizeof(u64) * vcpu_e500->gtlb_params[1].entries); if (vcpu_e500->h2g_tlb1_rmap) - memset(vcpu_e500->h2g_tlb1_rmap, - sizeof(unsigned int) * host_tlb_params[1].entries, 0); + memset(vcpu_e500->h2g_tlb1_rmap, 0, + sizeof(unsigned int) * host_tlb_params[1].entries); } static void clear_tlb_privs(struct kvmppc_vcpu_e500 *vcpu_e500)