From patchwork Tue Aug 14 19:35:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 177428 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 867172C007C for ; Wed, 15 Aug 2012 05:36:06 +1000 (EST) Received: from localhost ([::1]:58391 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1MuK-0003yy-Hl for incoming@patchwork.ozlabs.org; Tue, 14 Aug 2012 15:36:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Mty-0003Gi-3R for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:35:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T1Mtv-0001eP-Gv for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:35:42 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:63543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T1Mtv-0001e9-CH for qemu-devel@nongnu.org; Tue, 14 Aug 2012 15:35:39 -0400 Received: by yenm4 with SMTP id m4so887606yen.4 for ; Tue, 14 Aug 2012 12:35:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=86JWoze1Pst58OemFt6ElKrjCQ+w2HW57D/O7uJkKa8=; b=U0AUuI2i5tX2Z6ySab6ic1n9cWzEo8S3SRhjRhTm/Fid0/OBiLuebQIkZk+ftEWtO6 k8iTT/q0zyvCmihcibKQIGR5BgTECE6Cg3iKvHwVcYQHb/sov6zFZ2MgBPFRi2qBgTWz tOkHQtk77JLsxAn9rtvBZMFzPXwo/ItPCLDYhUoSNgrKo103xpk3Wr2shpZQF2cn3Gku wv98AZfdUp+1KHlXtoTkCDfdddX7soSnLtyrvCtfKjSfx2YYTEMFEQOjXSB1dq32TZhW ODxAZ8b8z23cU2Dm4MwT9kXdqoiTA91fy/B++qzv8P2z3TunuSazcSkjKclYMi6qPpft knXg== MIME-Version: 1.0 Received: by 10.50.193.201 with SMTP id hq9mr13544586igc.48.1344972938447; Tue, 14 Aug 2012 12:35:38 -0700 (PDT) Received: by 10.50.3.9 with HTTP; Tue, 14 Aug 2012 12:35:38 -0700 (PDT) In-Reply-To: References: <1344937236-611-1-git-send-email-peter.maydell@linaro.org> <1344937236-611-4-git-send-email-peter.maydell@linaro.org> Date: Tue, 14 Aug 2012 20:35:38 +0100 Message-ID: From: Peter Maydell To: Blue Swirl X-Gm-Message-State: ALoCoQl+NADK2ulG1jafk57WjxCdpjo7Mu+JvKP+4pIztNgsTjzDk/aaJtU8yxCVHmBeIp8eOfan X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.213.173 Cc: Anthony Liguori , Riku Voipio , qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [PATCH 03/10] linux-user: Move target_to_host_errno_table[] setup out of ioctl loop X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On 14 August 2012 19:58, Blue Swirl wrote: > On Tue, Aug 14, 2012 at 6:38 PM, Peter Maydell wrote: >> On 14 August 2012 19:27, Blue Swirl wrote: >>> On Tue, Aug 14, 2012 at 9:40 AM, Peter Maydell wrote: >>>> + /* Build target_to_host_errno_table[] table from >>>> + * host_to_target_errno_table[]. */ >>>> + for (i=0; i < ERRNO_TABLE_SIZE; i++) >>> >>> Please add spaces around '=' and braces. I've updated the pullreq branch. Since this was a trivial change I don't propose to rebroadcast all 10 patches. This is the diff between what was there and what is there now: (ie 'git diff 610dd40 3a1363a') Please pull :-) thanks -- PMM --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -4650,8 +4650,9 @@ void syscall_init(void) /* Build target_to_host_errno_table[] table from * host_to_target_errno_table[]. */ - for (i=0; i < ERRNO_TABLE_SIZE; i++) + for (i = 0; i < ERRNO_TABLE_SIZE; i++) { target_to_host_errno_table[host_to_target_errno_table[i]] = i; + } /* we patch the ioctl size if necessary. We rely on the fact that no ioctl has all the bits at '1' in the size field */