From patchwork Sat Jan 10 13:29:28 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Glendinning X-Patchwork-Id: 17737 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 29BEDDE76A for ; Sun, 11 Jan 2009 00:29:23 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbZAJN3A (ORCPT ); Sat, 10 Jan 2009 08:29:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754205AbZAJN27 (ORCPT ); Sat, 10 Jan 2009 08:28:59 -0500 Received: from [86.54.240.115] ([86.54.240.115]:60415 "EHLO drevil2.shawell.net" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753416AbZAJN24 (ORCPT ); Sat, 10 Jan 2009 08:28:56 -0500 Received: from localhost.localdomain (unknown [10.0.20.15]) by drevil2.shawell.net (Postfix) with ESMTP id 7A5663786B; Sat, 10 Jan 2009 13:28:53 +0000 (GMT) From: Steve Glendinning To: netdev@vger.kernel.org Cc: Ian Saturley , Steve Glendinning Subject: [PATCH 1/2] smsc911x: fix smsc911x_reg_read compiler warning Date: Sat, 10 Jan 2009 13:29:28 +0000 Message-Id: <1231594169-24988-1-git-send-email-steve.glendinning@smsc.com> X-Mailer: git-send-email 1.6.0.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org if this code path is ever hit, the platform_data struct isn't properly configured with a bus width flag so the device won't work (hence the BUG()). This patch adds a dummy return statement to eliminate this compiler warning: drivers/net/smsc911x.c: In function 'smsc911x_reg_read': drivers/net/smsc911x.c:148: warning: control reaches end of non-void function Signed-off-by: Steve Glendinning --- drivers/net/smsc911x.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c index dc3f110..1f443d8 100644 --- a/drivers/net/smsc911x.c +++ b/drivers/net/smsc911x.c @@ -144,6 +144,7 @@ static inline u32 smsc911x_reg_read(struct smsc911x_data *pdata, u32 reg) } BUG(); + return 0; } static inline void smsc911x_reg_write(struct smsc911x_data *pdata, u32 reg,