Patchwork [Quantal] Enables getabis to use local package copies

login
register
mail settings
Submitter Stefan Bader
Date Aug. 14, 2012, 8:30 a.m.
Message ID <1344933007-5192-1-git-send-email-stefan.bader@canonical.com>
Download mbox | patch
Permalink /patch/177187/
State New
Headers show

Comments

Stefan Bader - Aug. 14, 2012, 8:30 a.m.
This probably is something to let flow backwards. Though on
the other hand it is more likely to be an issue with a devel
tree not being uploaded to c-k-t.

-Stefan

From be6e8dd42326926e3f058577908718b2e2ba6ea6 Mon Sep 17 00:00:00 2001
From: Stefan Bader <stefan.bader@canonical.com>
Date: Tue, 14 Aug 2012 10:26:18 +0200
Subject: [PATCH] UBUNTU: (config) Enable getabis to use local package copies

If a package is not (yet) uploaded into the archive it will be
possible to place a copy of the .deb into the home directory and
it will get picked up.

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
---
 debian/scripts/misc/getabis |    6 ++++++
 1 file changed, 6 insertions(+)
Andy Whitcroft - Aug. 14, 2012, 8:55 a.m.
On Tue, Aug 14, 2012 at 10:30:07AM +0200, Stefan Bader wrote:
> This probably is something to let flow backwards. Though on
> the other hand it is more likely to be an issue with a devel
> tree not being uploaded to c-k-t.

Yeah I would say that this may as well just go into Quantal, before that
we build everything in the PPA anyhow.

I would mention that this is coming up because it is something we used
to be able to do with maint-startnewrelease which seems no longer works
because we have (sensibly) switched to "one getabis script to rule
them all".

> -Stefan
> 
> From be6e8dd42326926e3f058577908718b2e2ba6ea6 Mon Sep 17 00:00:00 2001
> From: Stefan Bader <stefan.bader@canonical.com>
> Date: Tue, 14 Aug 2012 10:26:18 +0200
> Subject: [PATCH] UBUNTU: (config) Enable getabis to use local package copies
> 
> If a package is not (yet) uploaded into the archive it will be
> possible to place a copy of the .deb into the home directory and
> it will get picked up.
> 
> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian/scripts/misc/getabis |    6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
> index c48199d..970c88f 100755
> --- a/debian/scripts/misc/getabis
> +++ b/debian/scripts/misc/getabis
> @@ -47,6 +47,12 @@ getall() {
>  		for prefix in $__package_prefixes
>  		do
>  			filename=${prefix}-${verabi}-${sub}_${verfull}_${arch}.deb
> +
> +			# Take local copy if it is there...
> +			if [ -f $HOME/$filename ]; then
> +				cp $HOME/$filename .
> +			fi
> +
>  			for r in "${repo_list[@]}"
>  			do
>  				if ! [ -f $filename ]; then
> -- 

This looks to do what I would expect.  Picking up a local copy from
home and dropping it in in preference.  I think the only thing I would
suggest is it should warn you it is doing it so if you have stuff lying
about in your home directory and it gets used you get fair warning of
your foolishness.

-apw

Patch

diff --git a/debian/scripts/misc/getabis b/debian/scripts/misc/getabis
index c48199d..970c88f 100755
--- a/debian/scripts/misc/getabis
+++ b/debian/scripts/misc/getabis
@@ -47,6 +47,12 @@  getall() {
 		for prefix in $__package_prefixes
 		do
 			filename=${prefix}-${verabi}-${sub}_${verfull}_${arch}.deb
+
+			# Take local copy if it is there...
+			if [ -f $HOME/$filename ]; then
+				cp $HOME/$filename .
+			fi
+
 			for r in "${repo_list[@]}"
 			do
 				if ! [ -f $filename ]; then