Patchwork dma: Fix stupid typo/thinko

login
register
mail settings
Submitter Benjamin Herrenschmidt
Date Aug. 14, 2012, 7:41 a.m.
Message ID <1344930107.2481.18.camel@pasglop>
Download mbox | patch
Permalink /patch/177174/
State New
Headers show

Comments

Benjamin Herrenschmidt - Aug. 14, 2012, 7:41 a.m.
Hi hard a brain fart when coding that function, it will
fail to "set" the memory beyond the first 512 bytes. This
is in turn causing guest crashes in ibmveth (spapr_llan.c
on the qemu side) due to the receive queue not being
properly initialized.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

Anthony, I believe this could/should go in ASAP :-)

Patch

diff --git a/dma-helpers.c b/dma-helpers.c
index 35cb500..53e47c6 100644
--- a/dma-helpers.c
+++ b/dma-helpers.c
@@ -24,8 +24,8 @@  static void do_dma_memory_set(dma_addr_t addr, uint8_t c, dma_addr_t len)
     while (len > 0) {
         l = len < FILLBUF_SIZE ? len : FILLBUF_SIZE;
         cpu_physical_memory_rw(addr, fillbuf, l, true);
-        len -= len;
-        addr += len;
+        len -= l;
+        addr += l;
     }
 }