From patchwork Tue Aug 14 04:20:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gary Funck X-Patchwork-Id: 177161 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7C0FF2C0087 for ; Tue, 14 Aug 2012 14:20:58 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1345522859; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type:Content-Disposition:User-Agent:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=x8Nd9dwfpJm5Bs5hcnNVyhw4gtg=; b=Q/WhlqzRokVCsdCtGXYpkiCOk8Tc1KZ7BkQctepBzA3RXDiLSAmYAK34RAfs7v OO/JomfK5WudY9LQQu/k6KwJbQh/AuQxodf2NAkbj77IKXzR8SPEkvgtMu2M3TuY vtjMH/0Z8ayhsRe5m/YgipjglmZhmEkoG/cZIlOmyeqso= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type:Content-Disposition:User-Agent:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=Wzsr2z2V+Pn6t0KvRLtYJY9BOVd1OHIfc4jFas41ga7g1RIPrecKU6lykP9SQz 3uFGfjqdfvmFoy22nuA45oepCdFXg7OC8EuhX3S3JxrYqhMhRVIgkeKz0aeo2GOM h0GNSdu09hyiRcrKLPiyuHDgB+vPuTbAe4SyGDbaIBF+Y=; Received: (qmail 7678 invoked by alias); 14 Aug 2012 04:20:48 -0000 Received: (qmail 7670 invoked by uid 22791); 14 Aug 2012 04:20:45 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL, BAYES_00, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.intrepid.com (HELO mail.intrepid.com) (74.95.8.113) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Aug 2012 04:20:31 +0000 Received: from screamer.local (screamer.local [10.10.1.2]) by mail.intrepid.com (8.14.5/8.14.5) with ESMTP id q7E4KVZs025761 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 13 Aug 2012 21:20:31 -0700 Received: from screamer.local (screamer.local [127.0.0.1]) by screamer.local (8.14.4/8.14.4) with ESMTP id q7E4KXpC025674; Mon, 13 Aug 2012 21:20:33 -0700 Received: (from gary@localhost) by screamer.local (8.14.4/8.14.4/Submit) id q7E4KWJk025673; Mon, 13 Aug 2012 21:20:32 -0700 Date: Mon, 13 Aug 2012 21:20:32 -0700 From: Gary Funck To: Gcc Patches Cc: jh@suse.cz, hjl.tools@gmail.com Subject: PATCH [x86_64] PR20020 - 128 bit structs not targeted to TImode Message-ID: <20120814042032.GB23649@intrepid.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Attached, is a patch to fix PR20020, and three test cases. This patch improves the code generated for structs that can be represented in a TImode value on an x86_64 target. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20020 The test cases scan the generated RTL and verify that TImode operations are present. Note that this patch will uncover a new test regression, described here: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=20020#c9 Index: gcc/config/i386/i386.h =================================================================== --- gcc/config/i386/i386.h (revision 190336) +++ gcc/config/i386/i386.h (working copy) @@ -1820,6 +1820,10 @@ do { \ #define BRANCH_COST(speed_p, predictable_p) \ (!(speed_p) ? 2 : (predictable_p) ? 0 : ix86_branch_cost) +/* An integer expression for the size in bits of the largest integer machine + mode that should actually be used. We allow pairs of registers. */ +#define MAX_FIXED_MODE_SIZE GET_MODE_BITSIZE (TARGET_64BIT ? TImode : DImode) + /* Define this macro as a C expression which is nonzero if accessing less than a word of memory (i.e. a `char' or a `short') is no faster than accessing a word of memory, i.e., if such access Index: gcc/testsuite/gcc.dg/pr20020-1.c =================================================================== --- gcc/testsuite/gcc.dg/pr20020-1.c (revision 0) +++ gcc/testsuite/gcc.dg/pr20020-1.c (revision 0) @@ -0,0 +1,25 @@ +/* Target is restricted to x86_64 type architectures, + to check that 128-bit struct's are represented + as TImode values. */ +/* { dg-require-effective-target int128 } */ +/* { dg-do compile { target { x86_64-*-* } } } */ +/* { dg-options "-O2 -fdump-rtl-expand" } */ + +struct shared_ptr_struct +{ + unsigned long long phase:48; + unsigned short thread:16; + void *addr; +}; +typedef struct shared_ptr_struct sptr_t; + +sptr_t S; + +sptr_t +sptr_result (void) +{ + return S; +} +/* { dg-final { scan-rtl-dump "\\\(set \\\(reg:TI \[0-9\]* \\\[ \\\]\\\)" "expand" } } */ +/* { dg-final { scan-rtl-dump "\\\(set \\\(reg/i:TI 0 ax\\\)" "expand" } } */ +/* { dg-final { cleanup-rtl-dump "expand" } } */ Index: gcc/testsuite/gcc.dg/pr20020-2.c =================================================================== --- gcc/testsuite/gcc.dg/pr20020-2.c (revision 0) +++ gcc/testsuite/gcc.dg/pr20020-2.c (revision 0) @@ -0,0 +1,23 @@ +/* Target is restricted to x86_64 type architectures, + to check that 128-bit struct's are represented + as TImode values. */ +/* { dg-require-effective-target int128 } */ +/* { dg-do compile { target { x86_64-*-* } } } */ +/* { dg-options "-O2 -fdump-rtl-expand" } */ + +struct shared_ptr_struct +{ + unsigned long long phase:48; + unsigned short thread:16; + void *addr; +}; +typedef struct shared_ptr_struct sptr_t; + +void +copy_sptr (sptr_t *dest, sptr_t src) +{ + *dest = src; +} + +/* { dg-final { scan-rtl-dump "\\\(set \\\(reg:TI \[0-9\]*" "expand" } } */ +/* { dg-final { cleanup-rtl-dump "expand" } } */ Index: gcc/testsuite/gcc.dg/pr20020-3.c =================================================================== --- gcc/testsuite/gcc.dg/pr20020-3.c (revision 0) +++ gcc/testsuite/gcc.dg/pr20020-3.c (revision 0) @@ -0,0 +1,26 @@ +/* Target is restricted to x86_64 type architectures, + to check that 128-bit struct's are represented + as TImode values. */ +/* { dg-require-effective-target int128 } */ +/* { dg-do compile { target { x86_64-*-* } } } */ +/* { dg-options "-O2 -fdump-rtl-expand" } */ + +struct shared_ptr_struct +{ + unsigned long long phase:48; + unsigned short thread:16; + void *addr; +}; +typedef struct shared_ptr_struct sptr_t; + +sptr_t sptr_1, sptr_2; + +void +copy_sptr (void) +{ + sptr_1 = sptr_2; +} + +/* { dg-final { scan-rtl-dump "\\\(set \\\(reg:TI \[0-9\]*" "expand" } } */ +/* { dg-final { scan-rtl-dump "\\\(set \\\(mem/c:TI" "expand" } } */ +/* { dg-final { cleanup-rtl-dump "expand" } } */