Patchwork mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

login
register
mail settings
Submitter Randy Dunlap
Date Jan. 10, 2009, 5:16 a.m.
Message ID <49682F42.8070304@oracle.com>
Download mbox | patch
Permalink /patch/17714/
State Accepted
Commit 57c1a24ee276a33190008243f986419e122c0dea
Headers show

Comments

Randy Dunlap - Jan. 10, 2009, 5:16 a.m.
Alexander Beregalov wrote:
> drivers/built-in.o: In function `lpddr_probe':
> drivers/mtd/lpddr/qinfo_probe.c:215:
> undefined reference to `lpddr_cmdset'
> 
> # CONFIG_MTD_LPDDR is not set
> CONFIG_MTD_QINFO_PROBE=y
> --

This patch has been posted, just needs to be merged (hint):
---


Signed-off-by: Alexey Korolev <akorolev@infradead.org>
---
Alexey Korolev - Jan. 11, 2009, 10:03 a.m.
Hi Randy,

I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch. 
Do you know whom I should ask to make this included?

Thanks,
Alexey

> > drivers/built-in.o: In function `lpddr_probe':
> > drivers/mtd/lpddr/qinfo_probe.c:215:
> > undefined reference to `lpddr_cmdset'
> > 
> > # CONFIG_MTD_LPDDR is not set
> > CONFIG_MTD_QINFO_PROBE=y
> > --
> 
> This patch has been posted, just needs to be merged (hint):
> ---
> 
> 
> Signed-off-by: Alexey Korolev <akorolev@infradead.org>
> ---
> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
> index acd4ea9..5a401d8 100644
> --- a/drivers/mtd/lpddr/Kconfig
> +++ b/drivers/mtd/lpddr/Kconfig
> @@ -12,6 +12,7 @@ config MTD_LPDDR
>  	  DDR memories, intended for battery-operated systems.
>  
>  config MTD_QINFO_PROBE
> +	depends on MTD_LPDDR
>  	tristate "Detect flash chips by QINFO probe"
>  	help
>  	    Device Information for LPDDR chips is offered through the Overlay
> 
>
Randy Dunlap - Jan. 11, 2009, 4:51 p.m.
Alexey Korolev wrote:
> Hi Randy,
> 
> I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch. 
> Do you know whom I should ask to make this included?

MAINTAINERS file:

MEMORY TECHNOLOGY DEVICES (MTD)
P:      David Woodhouse
M:      dwmw2@infradead.org

> Thanks,
> Alexey
> 
>>> drivers/built-in.o: In function `lpddr_probe':
>>> drivers/mtd/lpddr/qinfo_probe.c:215:
>>> undefined reference to `lpddr_cmdset'
>>>
>>> # CONFIG_MTD_LPDDR is not set
>>> CONFIG_MTD_QINFO_PROBE=y
>>> --
>> This patch has been posted, just needs to be merged (hint):
>> ---
>>
>>
>> Signed-off-by: Alexey Korolev <akorolev@infradead.org>
>> ---
>> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
>> index acd4ea9..5a401d8 100644
>> --- a/drivers/mtd/lpddr/Kconfig
>> +++ b/drivers/mtd/lpddr/Kconfig
>> @@ -12,6 +12,7 @@ config MTD_LPDDR
>>  	  DDR memories, intended for battery-operated systems.
>>  
>>  config MTD_QINFO_PROBE
>> +	depends on MTD_LPDDR
>>  	tristate "Detect flash chips by QINFO probe"
>>  	help
>>  	    Device Information for LPDDR chips is offered through the Overlay
>>
>>
Alexey Korolev - Jan. 11, 2009, 6:16 p.m.
Randy,
Yes, it has alreay been merged today.

David,
Thank you very much!

> 
> MAINTAINERS file:
> 
> MEMORY TECHNOLOGY DEVICES (MTD)
> P:      David Woodhouse
> M:      dwmw2@infradead.org
> 
> > Thanks,
> > Alexey
> > 
> >>> drivers/built-in.o: In function `lpddr_probe':
> >>> drivers/mtd/lpddr/qinfo_probe.c:215:
> >>> undefined reference to `lpddr_cmdset'
> >>>
> >>> # CONFIG_MTD_LPDDR is not set
> >>> CONFIG_MTD_QINFO_PROBE=y
> >>> --
> >> This patch has been posted, just needs to be merged (hint):
> >> ---
> >>
> >>
> >> Signed-off-by: Alexey Korolev <akorolev@infradead.org>
> >> ---
> >> diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
> >> index acd4ea9..5a401d8 100644
> >> --- a/drivers/mtd/lpddr/Kconfig
> >> +++ b/drivers/mtd/lpddr/Kconfig
> >> @@ -12,6 +12,7 @@ config MTD_LPDDR
> >>  	  DDR memories, intended for battery-operated systems.
> >>  
> >>  config MTD_QINFO_PROBE
> >> +	depends on MTD_LPDDR
> >>  	tristate "Detect flash chips by QINFO probe"
> >>  	help
> >>  	    Device Information for LPDDR chips is offered through the Overlay
> >>
> >>
> 
> 
> -- 
> ~Randy
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>

Patch

diff --git a/drivers/mtd/lpddr/Kconfig b/drivers/mtd/lpddr/Kconfig
index acd4ea9..5a401d8 100644
--- a/drivers/mtd/lpddr/Kconfig
+++ b/drivers/mtd/lpddr/Kconfig
@@ -12,6 +12,7 @@  config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay