From patchwork Mon Aug 13 19:18:33 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Luiz Capitulino X-Patchwork-Id: 177030 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 55B842C007E for ; Tue, 14 Aug 2012 05:18:06 +1000 (EST) Received: from localhost ([::1]:33364 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T109M-0001J4-DL for incoming@patchwork.ozlabs.org; Mon, 13 Aug 2012 15:18:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T109D-0001Ij-JU for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:17:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T109C-0003JR-Ef for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:17:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26745) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T109C-0003JN-5V for qemu-devel@nongnu.org; Mon, 13 Aug 2012 15:17:54 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DJHqkO014884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 13 Aug 2012 15:17:52 -0400 Received: from doriath.home (ovpn-113-98.phx2.redhat.com [10.3.113.98]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q7DJHomD004557; Mon, 13 Aug 2012 15:17:50 -0400 Date: Mon, 13 Aug 2012 16:18:33 -0300 From: Luiz Capitulino To: Anthony Liguori Message-ID: <20120813161833.72e1609e@doriath.home> In-Reply-To: <20120813141658.1bc8b15e@doriath.home> References: <1344614655-2195-1-git-send-email-aliguori@us.ibm.com> <20120813141658.1bc8b15e@doriath.home> Organization: Red Hat Mime-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: Peter Maydell , Alexander Graf , Eric Blake , qemu-devel@nongnu.org, Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 0/7] qapi: add commands to remove the need (v2) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org On Mon, 13 Aug 2012 14:16:58 -0300 Luiz Capitulino wrote: > On Fri, 10 Aug 2012 11:04:08 -0500 > Anthony Liguori wrote: > > > This series implements the necessary commands to implements danpb's idea to > > remove -help parsing in libvirt. We would introduce all of these commands in > > 1.2 and then change the -help output starting in 1.3. > > Applied to the qmp branch, thanks. Hmm, this series broke ppc-softmmu for me: In file included from /home/lcapitulino/work/src/qmp-unstable/target-ppc/translate_init.c:30:0, from /home/lcapitulino/work/src/qmp-unstable/target-ppc/translate.c:9404: ../qmp-commands.h:23:1: error: unknown type name ‘QDict’ ../qmp-commands.h:23:68: error: unknown type name ‘QObject’ But it's not its fault. The problem here is probably a patch in my error series that is doing header cleanup and qmp-commands.h was probably relying on qapi-types.h (or some of its include files) including qdict.h. I'm going to include the following patch in my pull request: Subject: [PATCH 36/48] scripts: qapi-commands.py: qmp-commands.h: include qdict.h qmp-commands.h declares several functions that have arguments of type QDict. However, qdict.h is not included. This will cause a build breakage when a file includes qmp-commands.h but doesn't include qdict.h. Signed-off-by: Luiz Capitulino --- scripts/qapi-commands.py | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/qapi-commands.py b/scripts/qapi-commands.py index 9eed40e..3c4678d 100644 --- a/scripts/qapi-commands.py +++ b/scripts/qapi-commands.py @@ -342,6 +342,7 @@ def gen_command_decl_prologue(header, guard, prefix=""): #define %(guard)s #include "%(prefix)sqapi-types.h" +#include "qdict.h" #include "error.h" ''',