From patchwork Mon Aug 13 10:50:50 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Juan Quintela X-Patchwork-Id: 176904 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6032C2C0091 for ; Mon, 13 Aug 2012 20:51:19 +1000 (EST) Received: from localhost ([::1]:51031 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0sEv-0001I5-B4 for incoming@patchwork.ozlabs.org; Mon, 13 Aug 2012 06:51:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0sEh-0001HT-Ay for qemu-devel@nongnu.org; Mon, 13 Aug 2012 06:51:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T0sEf-00036t-Ms for qemu-devel@nongnu.org; Mon, 13 Aug 2012 06:51:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T0sEf-00035H-6f for qemu-devel@nongnu.org; Mon, 13 Aug 2012 06:51:01 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q7DAp09p026272 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 13 Aug 2012 06:51:00 -0400 Received: from trasno.mitica (ovpn-116-54.ams2.redhat.com [10.36.116.54]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q7DAowcI014566; Mon, 13 Aug 2012 06:50:58 -0400 From: Juan Quintela To: qemu-devel@nongnu.org Date: Mon, 13 Aug 2012 12:50:50 +0200 Message-Id: <1344855057-32509-1-git-send-email-quintela@redhat.com> X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 Cc: eblake@redhat.com, lcapitulino@redhat.com Subject: [Qemu-devel] [RFC 0/7] Migration stats X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Hi This modifies the output of info migrate/qmp_query_migrate to add the stats that I got request for. - It moves total time to MigrationInfo instead of ram (luiz suggestion) - Prints the real downtime that we have had really, it prints the total downtime of the complete phase, but the downtime also includes the last ram_iterate phase. Working on fixing that one. - Prints the expected downtime of the last time that we synchronized the dirty bitmap with kvm. So we have one idea of what downtime value we need for migration to converge. - Prints the dirty_pages_rate, that is the number of pages that we have written in the last second. This one prints always zero. To fill it, I need the dirty bitmap changes on the migration_thread series. Patch series apply on top of the migration-next-20120808 series sent to anthony. What do I want to know: - is there any stat that you want? Once here, adding a new one should be easy. - examples are not done, waiting until people agree with what params are needed. - luiz added in case he has QMP commets. - erik added for libvirt comments. Added before is the link to the branch on my repository. The following changes since commit 346fe0c4c0b88f11a3d0c01c34d9a170d73429cc: Merge remote-tracking branch 'stefanha/trivial-patches' into staging (2012-08-11 19:49:03 -0500) are available in the git repository at: http://repo.or.cz/r/qemu/quintela.git migration-stats for you to fetch changes up to e0599012abfc4f9a68185c6f0a10a7b98c0a180f: migration: Add dirty_pages_rate to query migrate output (2012-08-13 12:33:35 +0200) Please review, and comment. Juan Quintela (7): migration: move total_time from ram stats to migration info migration: store end_time in a local variable migration: print total downtime for final phase of migration migration: rename expected_time to expected_downtime migration: export migration_get_current() migration: print expected downtime in info migrate migration: Add dirty_pages_rate to query migrate output arch_init.c | 19 +++++++++++-------- hmp.c | 16 ++++++++++++++-- migration.c | 19 ++++++++++++++----- migration.h | 4 ++++ qapi-schema.json | 26 +++++++++++++++++++------- 5 files changed, 62 insertions(+), 22 deletions(-)