Patchwork PATCH] ata: Kconfig: Elaborate that SFF is meant for legacy and PATA stuff

login
register
mail settings
Submitter Paul Menzel
Date Aug. 12, 2012, 9:54 p.m.
Message ID <1344808456.4275.66.camel@mattotaupa>
Download mbox | patch
Permalink /patch/176806/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Paul Menzel - Aug. 12, 2012, 9:54 p.m.
Date: Sun, 12 Aug 2012 23:43:42 +0200

Building Linux for an ASUS Eee PC 701 4G with

        ata2.00: CFA: SILICONMOTION SM223AC, , max UDMA/66
        ata2.00: 7815024 sectors, multi 0: LBA
        ata2.00: configured for UDMA/66
        scsi 1:0:0:0: Direct-Access     ATA      SILICONMOTION SM n/a  PQ: 0 ANSI: 5
        sd 1:0:0:0: [sda] 7815024 512-byte logical blocks: (4.00 GB/3.72 GiB)
        sd 1:0:0:0: [sda] Write Protect is off
        sd 1:0:0:0: [sda] Mode Sense: 00 3a 00 00
        sd 1:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
         sda: sda1
        sd 1:0:0:0: [sda] Attached SCSI disk
        sd 1:0:0:0: Attached scsi generic sg0 type 0

I followed the advice to not use the deprecated old PATA subsystem

        ATA/ATAPI/MFM/RLL support (DEPRECATED)  --->

and use the ATA subsystem instead.

        Serial ATA and Parallel ATA drivers  --->

Unfortunately I needed several tries to find out, that I needed the SFF
menu I had not selected before because I had never heard that term
before. I think it would have helped me, to have PATA or legacy IDE in
that item’s name.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
If you can improve the commit summary, I would be thankful.

 drivers/ata/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Jeff Garzik - Aug. 17, 2012, 5:32 p.m.
On 08/12/2012 05:54 PM, Paul Menzel wrote:
> Date: Sun, 12 Aug 2012 23:43:42 +0200
>
> Building Linux for an ASUS Eee PC 701 4G with
>
>          ata2.00: CFA: SILICONMOTION SM223AC, , max UDMA/66
>          ata2.00: 7815024 sectors, multi 0: LBA
>          ata2.00: configured for UDMA/66
>          scsi 1:0:0:0: Direct-Access     ATA      SILICONMOTION SM n/a  PQ: 0 ANSI: 5
>          sd 1:0:0:0: [sda] 7815024 512-byte logical blocks: (4.00 GB/3.72 GiB)
>          sd 1:0:0:0: [sda] Write Protect is off
>          sd 1:0:0:0: [sda] Mode Sense: 00 3a 00 00
>          sd 1:0:0:0: [sda] Write cache: disabled, read cache: enabled, doesn't support DPO or FUA
>           sda: sda1
>          sd 1:0:0:0: [sda] Attached SCSI disk
>          sd 1:0:0:0: Attached scsi generic sg0 type 0
>
> I followed the advice to not use the deprecated old PATA subsystem
>
>          ATA/ATAPI/MFM/RLL support (DEPRECATED)  --->
>
> and use the ATA subsystem instead.
>
>          Serial ATA and Parallel ATA drivers  --->
>
> Unfortunately I needed several tries to find out, that I needed the SFF
> menu I had not selected before because I had never heard that term
> before. I think it would have helped me, to have PATA or legacy IDE in
> that item’s name.
>
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> If you can improve the commit summary, I would be thankful.
>
>   drivers/ata/Kconfig |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
> index 2be8ef1..27cecd3 100644
> --- a/drivers/ata/Kconfig
> +++ b/drivers/ata/Kconfig
> @@ -115,7 +115,7 @@ config SATA_SIL24
>   	  If unsure, say N.
>
>   config ATA_SFF
> -	bool "ATA SFF support"
> +	bool "ATA SFF support (for legacy IDE and PATA)"
>   	default y
>   	help
>   	  This option adds support for ATA controllers with SFF

applied



--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig
index 2be8ef1..27cecd3 100644
--- a/drivers/ata/Kconfig
+++ b/drivers/ata/Kconfig
@@ -115,7 +115,7 @@  config SATA_SIL24
 	  If unsure, say N.
 
 config ATA_SFF
-	bool "ATA SFF support"
+	bool "ATA SFF support (for legacy IDE and PATA)"
 	default y
 	help
 	  This option adds support for ATA controllers with SFF