From patchwork Sat Aug 11 16:53:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Schmidt X-Patchwork-Id: 176693 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id A40752C00A8 for ; Sun, 12 Aug 2012 02:54:08 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1345308849; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC: Subject:References:In-Reply-To:Content-Type:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=d9rdzxzIzGBAiJQDjQlFLFwtnck=; b=F+ydZ0j4pfYILhKxCzL3zepGz/f+c8jMduAnOIAby9nAxQm6Eqri+MqgbCeZP1 aS8oXM0WNd7dm8aEQCPwwStonq8mTxCZO4W9/lHSif2t2oRcnHJDCErY8iA+o9xV G7Sq8uUGS7rBzBcgQvv1kN0ii8YUaFwR5plGS2zomb7CY= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=U72ZX9quMg+U+K0D564+h7yWTDEnG7k8WCXB1veblSwIyCJQmkKkQ8FlI7qhJ5 GIlX6tGCHKpIoRfr3hFfhtH7/GV/v3q6pGGVe3XjAkM69TW3rcAZ4ZK8Q4bZZbfG WvSVTW6buD2yK3r5+gFgyMf6aSX9jviA3uqjiubJCQfu8=; Received: (qmail 32492 invoked by alias); 11 Aug 2012 16:54:04 -0000 Received: (qmail 32478 invoked by uid 22791); 11 Aug 2012 16:54:03 -0000 X-SWARE-Spam-Status: No, hits=-4.4 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, KHOP_THREADED, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 11 Aug 2012 16:53:39 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1T0EwT-0004Kv-1F from Bernd_Schmidt@mentor.com ; Sat, 11 Aug 2012 09:53:37 -0700 Received: from SVR-IES-FEM-01.mgc.mentorg.com ([137.202.0.104]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sat, 11 Aug 2012 09:53:36 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.1.289.1; Sat, 11 Aug 2012 17:53:34 +0100 Message-ID: <50268DF6.3090308@codesourcery.com> Date: Sat, 11 Aug 2012 18:53:10 +0200 From: Bernd Schmidt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120730 Thunderbird/10.0.6 MIME-Version: 1.0 To: John David Anglin CC: John David Anglin , GCC Patches Subject: Re: Reload/i386 patch for secondary memory vs subregs References: <501BE12F.2000205@codesourcery.com> <20120811142012.GA16383@hiauly1.hia.nrc.ca> In-Reply-To: <20120811142012.GA16383@hiauly1.hia.nrc.ca> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org On 08/11/2012 04:20 PM, John David Anglin wrote: >> * reload1.c (replaced_subreg): New static function. >> (gen_reload): Use it when deciding whether to use secondary >> memory. > > This causes the following on hppa*-*-* (32-bit): > > ../../gcc/gcc/reload1.c: In function 'rtx_def* gen_reload(rtx, rtx, int, reload_ > type)': > ../../gcc/gcc/reload1.c:8494:12: error: unused variable 'tem1' [-Werror=unused-v > ariable] > rtx tem, tem1, tem2; > ^ > ../../gcc/gcc/reload1.c:8494:18: error: unused variable 'tem2' [-Werror=unused-variable] > rtx tem, tem1, tem2; > ^ > ../../gcc/gcc/reload1.c: At global scope: > ../../gcc/gcc/reload1.c:8477:1: error: 'rtx_def* replaced_subreg(rtx)' defined but not used [-Werror=unused-function] > replaced_subreg (rtx x) > ^ > cc1plus: all warnings being treated as errors > make[3]: *** [reload1.o] Error 1 Fixed. Bernd Index: gcc/ChangeLog =================================================================== --- gcc/ChangeLog (revision 190317) +++ gcc/ChangeLog (working copy) @@ -1,3 +1,8 @@ +2012-08-11 Bernd Schmidt + + * reload1.c (replaced_subreg, gen_reload): Add + SECONDARY_MEMORY_NEEDED ifdefs as necessary. + 2012-08-11 Jan Hubicka * lto-section-in.c (lto_section_name): Do not use "symtab" as part of Index: gcc/reload1.c =================================================================== --- gcc/reload1.c (revision 190252) +++ gcc/reload1.c (working copy) @@ -8469,6 +8469,7 @@ emit_insn_if_valid_for_reload (rtx insn) return NULL; } +#ifdef SECONDARY_MEMORY_NEEDED /* If X is not a subreg, return it unmodified. If it is a subreg, look up whether we made a replacement for the SUBREG_REG. Return either the replacement or the SUBREG_REG. */ @@ -8480,6 +8481,7 @@ replaced_subreg (rtx x) return find_replacement (&SUBREG_REG (x)); return x; } +#endif /* Emit code to perform a reload from IN (which may be a reload register) to OUT (which may also be a reload register). IN or OUT is from operand @@ -8491,7 +8493,10 @@ static rtx gen_reload (rtx out, rtx in, int opnum, enum reload_type type) { rtx last = get_last_insn (); - rtx tem, tem1, tem2; + rtx tem; +#ifdef SECONDARY_MEMORY_NEEDED + rtx tem1, tem2; +#endif /* If IN is a paradoxical SUBREG, remove it and try to put the opposite SUBREG on OUT. Likewise for a paradoxical SUBREG on OUT. */