Patchwork Unbreak lto plugin

login
register
mail settings
Submitter Jan Hubicka
Date Aug. 11, 2012, 3:51 p.m.
Message ID <20120811155109.GB14041@kam.mff.cuni.cz>
Download mbox | patch
Permalink /patch/176692/
State New
Headers show

Comments

Jan Hubicka - Aug. 11, 2012, 3:51 p.m.
Hi,
my prevoius LTO cleanup run into problem with plugin enabled builds;
lto-plugin is stupid enought to confused symtab_nodes section with symtab
because it ignores the suffixes.

Fixed thus. Comitted as obvoius.
Honza
Richard Guenther - Aug. 11, 2012, 5:13 p.m.
On Sat, Aug 11, 2012 at 5:51 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> my prevoius LTO cleanup run into problem with plugin enabled builds;
> lto-plugin is stupid enought to confused symtab_nodes section with symtab
> because it ignores the suffixes.

Err, I suppose we should fix the plugin as well.  It likely does that because
it thinks its suffixes for the partial-link stuff?

Richard.

> Fixed thus. Comitted as obvoius.
> Honza
>
> Index: ChangeLog
> ===================================================================
> --- ChangeLog   (revision 190316)
> +++ ChangeLog   (working copy)
> @@ -1,3 +1,8 @@
> +2012-08-11  Jan Hubicka  <jh@suse.cz>
> +
> +       * lto-section-in.c (lto_section_name): Do not use "symtab" as part of
> +       symtab_node sectoin name; it confuses plugin.
> +
>  2012-08-11  Uros Bizjak  <ubizjak@gmail.com>
>
>         * config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID
> Index: lto-section-in.c
> ===================================================================
> --- lto-section-in.c    (revision 190312)
> +++ lto-section-in.c    (working copy)
> @@ -55,7 +55,7 @@ const char *lto_section_name[LTO_N_SECTI
>    "jmpfuncs",
>    "pureconst",
>    "reference",
> -  "symtab_nodes",
> +  "symbol_nodes",
>    "opts",
>    "cgraphopt",
>    "inline"
Jan Hubicka - Aug. 12, 2012, 4:43 a.m.
> On Sat, Aug 11, 2012 at 5:51 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> > Hi,
> > my prevoius LTO cleanup run into problem with plugin enabled builds;
> > lto-plugin is stupid enought to confused symtab_nodes section with symtab
> > because it ignores the suffixes.
> 
> Err, I suppose we should fix the plugin as well.  It likely does that because
> it thinks its suffixes for the partial-link stuff?

Yes, I will test patch matching symtab. instead of symtab string. That should be enough.

Honza
> 
> Richard.
> 
> > Fixed thus. Comitted as obvoius.
> > Honza
> >
> > Index: ChangeLog
> > ===================================================================
> > --- ChangeLog   (revision 190316)
> > +++ ChangeLog   (working copy)
> > @@ -1,3 +1,8 @@
> > +2012-08-11  Jan Hubicka  <jh@suse.cz>
> > +
> > +       * lto-section-in.c (lto_section_name): Do not use "symtab" as part of
> > +       symtab_node sectoin name; it confuses plugin.
> > +
> >  2012-08-11  Uros Bizjak  <ubizjak@gmail.com>
> >
> >         * config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID
> > Index: lto-section-in.c
> > ===================================================================
> > --- lto-section-in.c    (revision 190312)
> > +++ lto-section-in.c    (working copy)
> > @@ -55,7 +55,7 @@ const char *lto_section_name[LTO_N_SECTI
> >    "jmpfuncs",
> >    "pureconst",
> >    "reference",
> > -  "symtab_nodes",
> > +  "symbol_nodes",
> >    "opts",
> >    "cgraphopt",
> >    "inline"

Patch

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 190316)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@ 
+2012-08-11  Jan Hubicka  <jh@suse.cz>
+
+	* lto-section-in.c (lto_section_name): Do not use "symtab" as part of
+	symtab_node sectoin name; it confuses plugin.
+
 2012-08-11  Uros Bizjak  <ubizjak@gmail.com>
 
 	* config/alpha/alpha.c (alpha_stdarg_optimize_hook): Shift DECL_UID
Index: lto-section-in.c
===================================================================
--- lto-section-in.c	(revision 190312)
+++ lto-section-in.c	(working copy)
@@ -55,7 +55,7 @@  const char *lto_section_name[LTO_N_SECTI
   "jmpfuncs",
   "pureconst",
   "reference",
-  "symtab_nodes",
+  "symbol_nodes",
   "opts",
   "cgraphopt",
   "inline"