| Message ID | 1344679527-13377-1-git-send-email-yefremov.denis@gmail.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Denis Efremov <yefremov.denis@gmail.com> Date: Sat, 11 Aug 2012 14:05:27 +0400 > - if (rcu_dereference(vlan->taps[i]) == q) > + if (rcu_dereference_protected(vlan->taps[i], > + lockdep_is_held(&macvtap_lock)) == q) You must use the proper combination of TAB character and spaces to line up the lockdep_is_held() argument with the first column after openning "(" on the previous line. Never be lazy and use only TABs. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c index 0737bd4..8ef11a8 100644 --- a/drivers/net/macvtap.c +++ b/drivers/net/macvtap.c @@ -94,7 +94,8 @@ static int get_slot(struct macvlan_dev *vlan, struct macvtap_queue *q) int i; for (i = 0; i < MAX_MACVTAP_QUEUES; i++) { - if (rcu_dereference(vlan->taps[i]) == q) + if (rcu_dereference_protected(vlan->taps[i], + lockdep_is_held(&macvtap_lock)) == q) return i; }
In this case it is not an error. rcu_dereference occurs in update section. Replacement by rcu_dereference_protected (with spinlock) in order to prevent lockdep complaint. Found by Linux Driver Verification project (linuxtesting.org) Signed-off-by: Denis Efremov <yefremov.denis@gmail.com> --- drivers/net/macvtap.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)