Patchwork [v2,Precise,SRU] UBUNTU: config: compile the rtc-pl031 driver as static on the highbank kernel flavour

login
register
mail settings
Submitter Chris Van Hoof
Date Aug. 11, 2012, 12:24 a.m.
Message ID <1344644691-24910-1-git-send-email-vanhoof@canonical.com>
Download mbox | patch
Permalink /patch/176654/
State New
Headers show

Comments

Chris Van Hoof - Aug. 11, 2012, 12:24 a.m.
From: Dann Frazier <dann.frazier@canonical.com>

Changes since v1:
    - Updated changelog entry with specifics on failure case
    - Ensured patch formatted against current precise master-next 

The rtc-pl031 driver is used for the RTC on the highbank
platform. Presently it is built as a module in Precise and
Quantal, making the driver unavailable in early boot, yielding
the following error on both releases:

./drivers/rtc/hctosys.c: unable to open rtc device (rtc0)

This behaviour prevents the ability to accurately check the
last-mounted time on the root filesystem.

BugLink: https://bugs.launchpad.net/bugs/1035110
Signed-off-by: Dann Frazier <dann.frazier@canonical.com>
Signed-off-by: Chris Van Hoof <vanhoof@canonical.com>
Cc: Ike Pan <ike.pan@canonical.com>
---
 debian.master/config/armel/config.common.armel     |    1 +
 debian.master/config/armhf/config.flavour.highbank |    1 +
 debian.master/config/armhf/config.flavour.omap     |    1 +
 debian.master/config/config.common.ubuntu          |    1 -
 4 files changed, 3 insertions(+), 1 deletion(-)
Herton Ronaldo Krzesinski - Aug. 13, 2012, 2:51 p.m.
On Fri, Aug 10, 2012 at 08:24:51PM -0400, Chris Van Hoof wrote:
> From: Dann Frazier <dann.frazier@canonical.com>
> 
> Changes since v1:
>     - Updated changelog entry with specifics on failure case
>     - Ensured patch formatted against current precise master-next 
> 
> The rtc-pl031 driver is used for the RTC on the highbank
> platform. Presently it is built as a module in Precise and
> Quantal, making the driver unavailable in early boot, yielding
> the following error on both releases:
> 
> ./drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
> 
> This behaviour prevents the ability to accurately check the
> last-mounted time on the root filesystem.

Ack, looking at configs, the main/platform RTC driver is builtin on
supported platforms. Perhaps we should have something on the enforcer
(rtc-cmos enforced on x86, this on highbank, RTC_DRV_TWL4030 on
armel/omap?)

Also, as already noted, because of the config shuffle modules.ignore
or ignore.modules is needed to be added.
Brad Figg - Aug. 13, 2012, 2:54 p.m.
On 08/10/2012 05:24 PM, Chris Van Hoof wrote:
> From: Dann Frazier <dann.frazier@canonical.com>
> 
> Changes since v1:
>     - Updated changelog entry with specifics on failure case
>     - Ensured patch formatted against current precise master-next 
> 
> The rtc-pl031 driver is used for the RTC on the highbank
> platform. Presently it is built as a module in Precise and
> Quantal, making the driver unavailable in early boot, yielding
> the following error on both releases:
> 
> ./drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
> 
> This behaviour prevents the ability to accurately check the
> last-mounted time on the root filesystem.
> 
> BugLink: https://bugs.launchpad.net/bugs/1035110
> Signed-off-by: Dann Frazier <dann.frazier@canonical.com>
> Signed-off-by: Chris Van Hoof <vanhoof@canonical.com>
> Cc: Ike Pan <ike.pan@canonical.com>
> ---
>  debian.master/config/armel/config.common.armel     |    1 +
>  debian.master/config/armhf/config.flavour.highbank |    1 +
>  debian.master/config/armhf/config.flavour.omap     |    1 +
>  debian.master/config/config.common.ubuntu          |    1 -
>  4 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/debian.master/config/armel/config.common.armel b/debian.master/config/armel/config.common.armel
> index dd040ba..d6806ad 100644
> --- a/debian.master/config/armel/config.common.armel
> +++ b/debian.master/config/armel/config.common.armel
> @@ -247,6 +247,7 @@ CONFIG_RFKILL_GPIO=m
>  CONFIG_RT2X00=m
>  CONFIG_RT2X00_LIB_DEBUGFS=y
>  CONFIG_RTC_DRV_CMOS=m
> +CONFIG_RTC_DRV_PL031=m
>  CONFIG_RTC_DRV_TWL4030=y
>  CONFIG_RTL8187=m
>  CONFIG_RTL8192CU=m
> diff --git a/debian.master/config/armhf/config.flavour.highbank b/debian.master/config/armhf/config.flavour.highbank
> index f9f927b..0dc8805 100644
> --- a/debian.master/config/armhf/config.flavour.highbank
> +++ b/debian.master/config/armhf/config.flavour.highbank
> @@ -165,6 +165,7 @@ CONFIG_REGMAP_SPI=m
>  # CONFIG_RELAY is not set
>  # CONFIG_RFKILL_GPIO is not set
>  # CONFIG_RT2X00 is not set
> +CONFIG_RTC_DRV_PL031=y
>  CONFIG_RTC_DRV_TWL4030=m
>  # CONFIG_RTL8187 is not set
>  # CONFIG_RTL8192CU is not set
> diff --git a/debian.master/config/armhf/config.flavour.omap b/debian.master/config/armhf/config.flavour.omap
> index b674f3f..c20a297 100644
> --- a/debian.master/config/armhf/config.flavour.omap
> +++ b/debian.master/config/armhf/config.flavour.omap
> @@ -165,6 +165,7 @@ CONFIG_REISERFS_FS_SECURITY=y
>  CONFIG_RELAY=y
>  CONFIG_RFKILL_GPIO=m
>  CONFIG_RT2X00=m
> +CONFIG_RTC_DRV_PL031=m
>  CONFIG_RTC_DRV_TWL4030=y
>  CONFIG_RTL8187=m
>  CONFIG_RTL8192CU=m
> diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
> index 23e5439..bcc53f6 100644
> --- a/debian.master/config/config.common.ubuntu
> +++ b/debian.master/config/config.common.ubuntu
> @@ -4243,7 +4243,6 @@ CONFIG_RTC_DRV_PCF50633=m
>  CONFIG_RTC_DRV_PCF8563=m
>  CONFIG_RTC_DRV_PCF8583=m
>  CONFIG_RTC_DRV_PL030=m
> -CONFIG_RTC_DRV_PL031=m
>  CONFIG_RTC_DRV_PS3=m
>  CONFIG_RTC_DRV_R9701=m
>  CONFIG_RTC_DRV_RP5C01=m
>
Herton Ronaldo Krzesinski - Aug. 14, 2012, 1:53 p.m.
Applied to precise master-next with minor changelog cleanup/tweaks. Also
added modules.ignore for armhf.

Patch

diff --git a/debian.master/config/armel/config.common.armel b/debian.master/config/armel/config.common.armel
index dd040ba..d6806ad 100644
--- a/debian.master/config/armel/config.common.armel
+++ b/debian.master/config/armel/config.common.armel
@@ -247,6 +247,7 @@  CONFIG_RFKILL_GPIO=m
 CONFIG_RT2X00=m
 CONFIG_RT2X00_LIB_DEBUGFS=y
 CONFIG_RTC_DRV_CMOS=m
+CONFIG_RTC_DRV_PL031=m
 CONFIG_RTC_DRV_TWL4030=y
 CONFIG_RTL8187=m
 CONFIG_RTL8192CU=m
diff --git a/debian.master/config/armhf/config.flavour.highbank b/debian.master/config/armhf/config.flavour.highbank
index f9f927b..0dc8805 100644
--- a/debian.master/config/armhf/config.flavour.highbank
+++ b/debian.master/config/armhf/config.flavour.highbank
@@ -165,6 +165,7 @@  CONFIG_REGMAP_SPI=m
 # CONFIG_RELAY is not set
 # CONFIG_RFKILL_GPIO is not set
 # CONFIG_RT2X00 is not set
+CONFIG_RTC_DRV_PL031=y
 CONFIG_RTC_DRV_TWL4030=m
 # CONFIG_RTL8187 is not set
 # CONFIG_RTL8192CU is not set
diff --git a/debian.master/config/armhf/config.flavour.omap b/debian.master/config/armhf/config.flavour.omap
index b674f3f..c20a297 100644
--- a/debian.master/config/armhf/config.flavour.omap
+++ b/debian.master/config/armhf/config.flavour.omap
@@ -165,6 +165,7 @@  CONFIG_REISERFS_FS_SECURITY=y
 CONFIG_RELAY=y
 CONFIG_RFKILL_GPIO=m
 CONFIG_RT2X00=m
+CONFIG_RTC_DRV_PL031=m
 CONFIG_RTC_DRV_TWL4030=y
 CONFIG_RTL8187=m
 CONFIG_RTL8192CU=m
diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu
index 23e5439..bcc53f6 100644
--- a/debian.master/config/config.common.ubuntu
+++ b/debian.master/config/config.common.ubuntu
@@ -4243,7 +4243,6 @@  CONFIG_RTC_DRV_PCF50633=m
 CONFIG_RTC_DRV_PCF8563=m
 CONFIG_RTC_DRV_PCF8583=m
 CONFIG_RTC_DRV_PL030=m
-CONFIG_RTC_DRV_PL031=m
 CONFIG_RTC_DRV_PS3=m
 CONFIG_RTC_DRV_R9701=m
 CONFIG_RTC_DRV_RP5C01=m