| Message ID | 2025492723.2284420.1344636316297.JavaMail.root@advansee.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Hi Benoît, On Sat, 11 Aug 2012 00:05:16 +0200 (CEST), Benoît Thébaudeau <benoit.thebaudeau@advansee.com> wrote: > We don't need to return to cpu_init_crit after calling lowlevel_init, so > lowlevel_init can directly return to the caller of cpu_init_crit. > > Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com> > Cc: Albert Aribaud <albert.u.boot@aribaud.net> > --- > .../arch/arm/cpu/armv7/start.S | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S > index aee27fd..e8e533e 100644 > --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S > +++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S > @@ -357,10 +357,7 @@ ENTRY(cpu_init_crit) > * basic memory. Go here to bump up clock rate and handle > * wake up conditions. > */ > - mov ip, lr @ persevere link reg across call > - bl lowlevel_init @ go setup pll,mux,memory > - mov lr, ip @ restore link > - mov pc, lr @ back to my caller > + b lowlevel_init @ go setup pll,mux,memory > ENDPROC(cpu_init_crit) > #endif > > Applied to u-boot-arm/master, thanks! Amicalement,
diff --git u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S u-boot-4d3c95f/arch/arm/cpu/armv7/start.S index aee27fd..e8e533e 100644 --- u-boot-4d3c95f.orig/arch/arm/cpu/armv7/start.S +++ u-boot-4d3c95f/arch/arm/cpu/armv7/start.S @@ -357,10 +357,7 @@ ENTRY(cpu_init_crit) * basic memory. Go here to bump up clock rate and handle * wake up conditions. */ - mov ip, lr @ persevere link reg across call - bl lowlevel_init @ go setup pll,mux,memory - mov lr, ip @ restore link - mov pc, lr @ back to my caller + b lowlevel_init @ go setup pll,mux,memory ENDPROC(cpu_init_crit) #endif
We don't need to return to cpu_init_crit after calling lowlevel_init, so lowlevel_init can directly return to the caller of cpu_init_crit. Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau@advansee.com> Cc: Albert Aribaud <albert.u.boot@aribaud.net> --- .../arch/arm/cpu/armv7/start.S | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)