From patchwork Thu Aug 9 18:11:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Fu, Chao-Ying" X-Patchwork-Id: 176205 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 76CF52C00A7 for ; Fri, 10 Aug 2012 04:11:57 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1345140717; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version:Mailing-List: Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:Sender:Delivered-To; bh=Jk7TiPEZpTa7xsPMECHFSfnoGm4=; b=CgrQDDX/Cv9EkYmMc3UVlDdXBdvEiKqOYmkalOAz4iirE38GcYN40xyaUND2EH +gBzxLXdfHrvlwV+YWAzWMeLs+eZiOYqXjA0MnqprPw9YIXHRh/xPjIvxtpwOE5b 8+tDK9DB/94x1RXScuDPnNTuKWlBGQKJxL+LcDaJrMZzU= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:From:To:CC:Subject:Date:Message-ID:References:In-Reply-To:x-ems-proccessed:x-ems-stamp:Content-Type:Content-Transfer-Encoding:MIME-Version:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=OffkDhO3pg110VoAJjWVfiJa0K9VetGhFPl0fx7zqGk25Ys6osNYNSnvsA11nz tV9amItlQ/G8jl0LHB5gMwEl7pAPUkHwgpdVBQ+gSQk9aJfroJpG6lbwu85mIkdO quAqVTgNhbzZ1cFoAIkFxA1y1ehSuxGwLT3V1zn/5yFxc=; Received: (qmail 21277 invoked by alias); 9 Aug 2012 18:11:52 -0000 Received: (qmail 21264 invoked by uid 22791); 9 Aug 2012 18:11:51 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL, BAYES_00, KHOP_THREADED, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from dns1.mips.com (HELO dns1.mips.com) (12.201.5.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Aug 2012 18:11:38 +0000 Received: from exchdb01.mips.com (exchhub01.mips.com [192.168.36.84]) by dns1.mips.com (8.13.8/8.13.8) with ESMTP id q79IBZkx030128; Thu, 9 Aug 2012 11:11:35 -0700 Received: from EXCHDB03.MIPS.com ([fe80::6df1:ae84:797e:9076]) by exchhub01.mips.com ([::1]) with mapi id 14.01.0270.001; Thu, 9 Aug 2012 11:11:32 -0700 From: "Fu, Chao-Ying" To: "H.J. Lu" , "gcc-patches@gcc.gnu.org" CC: Maxim Kuvyrkov Subject: RE: PATCH: PR bootstrap/54209: [4.8 Regression] Failed to build gcc for Android/x86 Date: Thu, 9 Aug 2012 18:11:32 +0000 Message-ID: <7C6479EB2BF52547AC332FD6034646DA01448EB6A5@exchdb03.mips.com> References: <20120809163953.GA5322@intel.com> <7C6479EB2BF52547AC332FD6034646DA01448EB694@exchdb03.mips.com> In-Reply-To: <7C6479EB2BF52547AC332FD6034646DA01448EB694@exchdb03.mips.com> x-ems-proccessed: 6LP3oGfGVdcdb8o1aBnt6w== x-ems-stamp: EGoXCxmO/VExXwEvpLnmXw== MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org > > Hi, > > > > Bionic C library doesn't provide link.h. This patch > reverts revision > > 186788: > > > > http://gcc.gnu.org/ml/gcc-cvs/2012-04/msg00740.html > > > > OK to install? > > > > Thanks. > > > > H.J. > > --- > > 2012-08-09 H.J. Lu > > > > PR bootstrap/54209 > > * unwind-dw2-fde-dip.c (USE_PT_GNU_EH_FRAME): Don't define for > > Bionic C library. > > > > diff --git a/libgcc/unwind-dw2-fde-dip.c > b/libgcc/unwind-dw2-fde-dip.c > > index 92f8ab5..f57dc8c 100644 > > --- a/libgcc/unwind-dw2-fde-dip.c > > +++ b/libgcc/unwind-dw2-fde-dip.c > > @@ -54,11 +54,6 @@ > > #endif > > > > #if !defined(inhibit_libc) && defined(HAVE_LD_EH_FRAME_HDR) \ > > - && defined(__BIONIC__) > > -# define USE_PT_GNU_EH_FRAME > > -#endif > > - > > -#if !defined(inhibit_libc) && defined(HAVE_LD_EH_FRAME_HDR) \ > > && defined(__FreeBSD__) && __FreeBSD__ >= 7 > > # define ElfW __ElfN > > # define USE_PT_GNU_EH_FRAME > > > > How about this patch? Just enable it for MIPS that > provides link.h in Android NDK. > Thanks a lot! > > Regards, > Chao-ying > > Index: unwind-dw2-fde-dip.c > =================================================================== > --- unwind-dw2-fde-dip.c (revision 190260) > +++ unwind-dw2-fde-dip.c (working copy) > @@ -55,6 +55,7 @@ > > #if !defined(inhibit_libc) && defined(HAVE_LD_EH_FRAME_HDR) \ > && defined(__BIONIC__) > + && defined(__mips__) > # define USE_PT_GNU_EH_FRAME > #endif > Sorry, I forgot \ in the previous patch. Ex: Index: unwind-dw2-fde-dip.c =================================================================== --- unwind-dw2-fde-dip.c (revision 190260) +++ unwind-dw2-fde-dip.c (working copy) @@ -54,7 +54,8 @@ #endif #if !defined(inhibit_libc) && defined(HAVE_LD_EH_FRAME_HDR) \ - && defined(__BIONIC__) + && defined(__BIONIC__) \ + && defined(__mips__) # define USE_PT_GNU_EH_FRAME #endif