Patchwork ubifs: remove __DATE__ and __TIME__

login
register
mail settings
Submitter Jiri Slaby
Date Aug. 9, 2012, 5:43 p.m.
Message ID <1344534194-16321-1-git-send-email-jslaby@suse.cz>
Download mbox | patch
Permalink /patch/176202/
State Accepted
Commit e2441b43190efe0c1e156455b35397ac5efd2610
Headers show

Comments

Jiri Slaby - Aug. 9, 2012, 5:43 p.m.
This tag is useless and it breaks automatic builds. It causes rebuilds
for packages that depend on kernel for no real reason.

Further, quoting Michal, who removed most of the users already:
The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: linux-mtd@lists.infradead.org
Cc: Michal Marek <mmarek@suse.cz>
---
 fs/ubifs/super.c |    1 -
 1 file changed, 1 deletion(-)
Jiri Slaby - Aug. 24, 2012, 11:51 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/24/2012 01:54 PM, Artem Bityutskiy wrote:
> On Thu, 2012-08-09 at 19:43 +0200, Jiri Slaby wrote:
>> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c index
>> e354832..67af316 100644 --- a/fs/ubifs/super.c +++
>> b/fs/ubifs/super.c @@ -1431,7 +1431,6 @@ static int
>> mount_ubifs(struct ubifs_info *c) ubifs_msg("reserved for root:
>> %llu bytes (%llu KiB)", c->report_rp_size, c->report_rp_size >>
>> 10);
>> 
>> -	dbg_msg("compiled on:         " __DATE__ " at " __TIME__); 
>> dbg_msg("min. I/O unit size:  %d bytes", c->min_io_size); 
>> dbg_msg("max. write size:     %d bytes", c->max_write_size); 
>> dbg_msg("LEB size:            %d bytes (%d KiB)",
> 
> Pushed to linux-ubifs.git, thanks! Does it make sense to hurry up
> and send this to 3.6? Or it can be merged to 3.7 normally?

No need to rush. We have the patch in a local queue anyway.

thanks,
- -- 
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJQN2qmAAoJEL0lsQQGtHBJi/EP/AxRThCd3Kbp2QS0cWlR2d81
AlYi+/TWC8P3NOjfoW3dZibn23DsZ45Dgs0MR9V1AvaKAZ81MIVE7dTQKJxalgen
R8bugSb8j9YssnuSmQaqmGgsvDXzW3VCLaGgwSVlOJ1sTJgG0A7r9/vNf1aPLG5J
oDthCQswltnyl7iRuYMLB3G1mtP+ml2rW9GyKhQfR9/380gPDsfx5PuCwjqvS3we
zn81GS54RTe0C8kROUuyIuLGN+NVPoGXQVp3IIww7cN6G/xb7WDm5sle0VNYYCiC
VQCXfApJWkOaORqKRfBHMLqfgkcaegT+uQA0ELon0T5GTfLrTGHnmijYKLbYhVK9
suUdLMOSrk5Pcu8KYmT3ti7FP+kTJE9+lJAqdCpedSBEzn88TGn+5gY9APG+Nsy2
9YkvwAelnzdRlf0AO5RXfCUua6wk/UNSNrZJDex1fflYCjBXdlneeV7akDBVqGW8
9Vklwmp5PeBtWt2kh7U9cyxDRiC55df8DKG1I/TGZ7YdtL6O+mtFegVMkc5NA2rp
DXFgYDnhthaqfGDXLHIiGTS+B7twmsVI1kwXEY/Tsga0JS7WQu6rgmbn88JJFwI4
PS7VT0EQ4ZiAH2olXu9fpFbJrI+s7ksWw5pC/4ri15wAHVZd8i5dZkhbX60XM7ns
Xd3BJrukZbugw0iiMVBv
=7Zm3
-----END PGP SIGNATURE-----
Artem Bityutskiy - Aug. 24, 2012, 11:54 a.m.
On Thu, 2012-08-09 at 19:43 +0200, Jiri Slaby wrote:
> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
> index e354832..67af316 100644
> --- a/fs/ubifs/super.c
> +++ b/fs/ubifs/super.c
> @@ -1431,7 +1431,6 @@ static int mount_ubifs(struct ubifs_info *c)
>  	ubifs_msg("reserved for root:  %llu bytes (%llu KiB)",
>  		c->report_rp_size, c->report_rp_size >> 10);
>  
> -	dbg_msg("compiled on:         " __DATE__ " at " __TIME__);
>  	dbg_msg("min. I/O unit size:  %d bytes", c->min_io_size);
>  	dbg_msg("max. write size:     %d bytes", c->max_write_size);
>  	dbg_msg("LEB size:            %d bytes (%d KiB)",

Pushed to linux-ubifs.git, thanks! Does it make sense to hurry up and
send this to 3.6? Or it can be merged to 3.7 normally?

Patch

diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index e354832..67af316 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -1431,7 +1431,6 @@  static int mount_ubifs(struct ubifs_info *c)
 	ubifs_msg("reserved for root:  %llu bytes (%llu KiB)",
 		c->report_rp_size, c->report_rp_size >> 10);
 
-	dbg_msg("compiled on:         " __DATE__ " at " __TIME__);
 	dbg_msg("min. I/O unit size:  %d bytes", c->min_io_size);
 	dbg_msg("max. write size:     %d bytes", c->max_write_size);
 	dbg_msg("LEB size:            %d bytes (%d KiB)",