Patchwork [23/23] xtensa: Suppress unused default drives

login
register
mail settings
Submitter Markus Armbruster
Date Aug. 9, 2012, 1:31 p.m.
Message ID <1344519084-21847-24-git-send-email-armbru@redhat.com>
Download mbox | patch
Permalink /patch/176161/
State New
Headers show

Comments

Markus Armbruster - Aug. 9, 2012, 1:31 p.m.
Cc: Max Filippov <jcmvbkbc@gmail.com>

Suppress default floppy, CD-ROM and SD card drives for machines lx60,
lx200, sim.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 hw/xtensa_lx60.c | 6 ++++++
 hw/xtensa_sim.c  | 3 +++
 2 files changed, 9 insertions(+)
Max Filippov - Aug. 15, 2012, 12:51 p.m.
On Thu, Aug 9, 2012 at 5:31 PM, Markus Armbruster <armbru@redhat.com> wrote:
> Cc: Max Filippov <jcmvbkbc@gmail.com>
>
> Suppress default floppy, CD-ROM and SD card drives for machines lx60,
> lx200, sim.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Acked-by: Max Filippov <jcmvbkbc@gmail.com>

Though I'd agree with Andreas about inverting default device creation logic.

Patch

diff --git a/hw/xtensa_lx60.c b/hw/xtensa_lx60.c
index c4f616f..f89e255 100644
--- a/hw/xtensa_lx60.c
+++ b/hw/xtensa_lx60.c
@@ -303,6 +303,9 @@  static QEMUMachine xtensa_lx60_machine = {
     .desc = "lx60 EVB (dc232b)",
     .init = xtensa_lx60_init,
     .max_cpus = 4,
+    .no_floppy = 1,
+    .no_cdrom = 1,
+    .no_sdcard = 1,
 };
 
 static QEMUMachine xtensa_lx200_machine = {
@@ -310,6 +313,9 @@  static QEMUMachine xtensa_lx200_machine = {
     .desc = "lx200 EVB (dc232b)",
     .init = xtensa_lx200_init,
     .max_cpus = 4,
+    .no_floppy = 1,
+    .no_cdrom = 1,
+    .no_sdcard = 1,
 };
 
 static void xtensa_lx_machines_init(void)
diff --git a/hw/xtensa_sim.c b/hw/xtensa_sim.c
index 1ce07fb..f1246d6 100644
--- a/hw/xtensa_sim.c
+++ b/hw/xtensa_sim.c
@@ -113,6 +113,9 @@  static QEMUMachine xtensa_sim_machine = {
     .desc = "sim machine (dc232b)",
     .init = xtensa_sim_init,
     .max_cpus = 4,
+    .no_floppy = 1,
+    .no_cdrom = 1,
+    .no_sdcard = 1,
 };
 
 static void xtensa_sim_machine_init(void)