Patchwork [07/14] bridge: add some comments for NETDEV_RELEASE

login
register
mail settings
Submitter Amerigo Wang
Date Aug. 9, 2012, 3 p.m.
Message ID <1344524426-11588-8-git-send-email-amwang@redhat.com>
Download mbox | patch
Permalink /patch/176158/
State Changes Requested
Delegated to: David Miller
Headers show

Comments

Amerigo Wang - Aug. 9, 2012, 3 p.m.
Add comments on why we don't notify NETDEV_RELEASE.

Cc: David Miller <davem@davemloft.net>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: Cong Wang <amwang@redhat.com>
---
 net/bridge/br_if.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

Patch

diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index 171fd6b..bf47d4f 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -427,6 +427,9 @@  int br_del_if(struct net_bridge *br, struct net_device *dev)
 	if (!p || p->br != br)
 		return -EINVAL;
 
+	/* We don't notify NETDEV_RELEASE event, as this will
+	 * stop netconsole on the bridge.
+	 */
 	del_nbp(p);
 
 	spin_lock_bh(&br->lock);