From patchwork Fri Jan 9 20:45:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: stephen hemminger X-Patchwork-Id: 17594 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 626E5DE555 for ; Sat, 10 Jan 2009 07:46:10 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbZAIUqG (ORCPT ); Fri, 9 Jan 2009 15:46:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753520AbZAIUqE (ORCPT ); Fri, 9 Jan 2009 15:46:04 -0500 Received: from mail.vyatta.com ([76.74.103.46]:41434 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbZAIUqD (ORCPT ); Fri, 9 Jan 2009 15:46:03 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.vyatta.com (Postfix) with ESMTP id 3D21C4F4F7C; Fri, 9 Jan 2009 12:46:05 -0800 (PST) X-Virus-Scanned: amavisd-new at tahiti.vyatta.com Received: from mail.vyatta.com ([127.0.0.1]) by localhost (mail.vyatta.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7AFJP2k4tOPf; Fri, 9 Jan 2009 12:46:04 -0800 (PST) Received: from s6510 (pool-96-225-207-155.ptldor.fios.verizon.net [96.225.207.155]) by mail.vyatta.com (Postfix) with ESMTP id 65DCD4F4F74; Fri, 9 Jan 2009 12:46:04 -0800 (PST) Date: Fri, 9 Jan 2009 12:45:37 -0800 From: Stephen Hemminger To: "David S. Miller" Cc: netdev@vger.kernel.org Subject: [PATCH 2/2] netdev: missing validate_address hooks Message-ID: <20090109124537.346c61d8@s6510> In-Reply-To: <20090109124427.71d15306@s6510> References: <20090109124427.71d15306@s6510> Organization: Vyatta X-Mailer: Claws Mail 3.6.1 (GTK+ 2.14.5; i386-redhat-linux-gnu) Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Some devices were converted incorrectly and are missing the validate address hooks. Signed-off-by: Stephen Hemminger --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/net/acenic.c 2009-01-08 08:30:09.000000000 -0800 +++ b/drivers/net/acenic.c 2009-01-09 12:40:17.000000000 -0800 @@ -460,6 +460,7 @@ static const struct net_device_ops ace_n .ndo_get_stats = ace_get_stats, .ndo_start_xmit = ace_start_xmit, .ndo_set_multicast_list = ace_set_multicast_list, + .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = ace_set_mac_addr, .ndo_change_mtu = ace_change_mtu, #if ACENIC_DO_VLAN --- a/drivers/net/arm/ks8695net.c 2009-01-08 08:30:09.000000000 -0800 +++ b/drivers/net/arm/ks8695net.c 2009-01-09 12:40:37.000000000 -0800 @@ -1357,6 +1357,7 @@ static const struct net_device_ops ks869 .ndo_start_xmit = ks8695_start_xmit, .ndo_tx_timeout = ks8695_timeout, .ndo_set_mac_address = ks8695_set_mac, + .ndo_validate_addr = eth_validate_addr, .ndo_set_multicast_list = ks8695_set_multicast, }; --- a/drivers/net/mlx4/en_netdev.c 2009-01-08 08:30:12.000000000 -0800 +++ b/drivers/net/mlx4/en_netdev.c 2009-01-09 12:41:47.000000000 -0800 @@ -952,6 +952,7 @@ static const struct net_device_ops mlx4_ .ndo_get_stats = mlx4_en_get_stats, .ndo_set_multicast_list = mlx4_en_set_multicast, .ndo_set_mac_address = mlx4_en_set_mac, + .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = mlx4_en_change_mtu, .ndo_tx_timeout = mlx4_en_tx_timeout, .ndo_vlan_rx_register = mlx4_en_vlan_rx_register,