| Submitter | stephen hemminger |
|---|---|
| Date | Jan. 9, 2009, 8:45 p.m. |
| Message ID | <20090109124537.346c61d8@s6510> |
| Download | mbox | patch |
| Permalink | /patch/17594/ |
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
Comments
From: Stephen Hemminger <shemminger@vyatta.com> Date: Fri, 9 Jan 2009 12:45:37 -0800 > Some devices were converted incorrectly and are missing the validate > address hooks. > > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
--- a/drivers/net/acenic.c 2009-01-08 08:30:09.000000000 -0800 +++ b/drivers/net/acenic.c 2009-01-09 12:40:17.000000000 -0800 @@ -460,6 +460,7 @@ static const struct net_device_ops ace_n .ndo_get_stats = ace_get_stats, .ndo_start_xmit = ace_start_xmit, .ndo_set_multicast_list = ace_set_multicast_list, + .ndo_validate_addr = eth_validate_addr, .ndo_set_mac_address = ace_set_mac_addr, .ndo_change_mtu = ace_change_mtu, #if ACENIC_DO_VLAN --- a/drivers/net/arm/ks8695net.c 2009-01-08 08:30:09.000000000 -0800 +++ b/drivers/net/arm/ks8695net.c 2009-01-09 12:40:37.000000000 -0800 @@ -1357,6 +1357,7 @@ static const struct net_device_ops ks869 .ndo_start_xmit = ks8695_start_xmit, .ndo_tx_timeout = ks8695_timeout, .ndo_set_mac_address = ks8695_set_mac, + .ndo_validate_addr = eth_validate_addr, .ndo_set_multicast_list = ks8695_set_multicast, }; --- a/drivers/net/mlx4/en_netdev.c 2009-01-08 08:30:12.000000000 -0800 +++ b/drivers/net/mlx4/en_netdev.c 2009-01-09 12:41:47.000000000 -0800 @@ -952,6 +952,7 @@ static const struct net_device_ops mlx4_ .ndo_get_stats = mlx4_en_get_stats, .ndo_set_multicast_list = mlx4_en_set_multicast, .ndo_set_mac_address = mlx4_en_set_mac, + .ndo_validate_addr = eth_validate_addr, .ndo_change_mtu = mlx4_en_change_mtu, .ndo_tx_timeout = mlx4_en_tx_timeout, .ndo_vlan_rx_register = mlx4_en_vlan_rx_register,
Some devices were converted incorrectly and are missing the validate address hooks. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html