From patchwork Wed Aug 8 10:11:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: rtc-pcf2123: Initialize dynamic sysfs attributes Date: Wed, 08 Aug 2012 00:11:25 -0000 From: Ilya Shchepetkov X-Patchwork-Id: 175889 Message-Id: <1344420685-30727-1-git-send-email-shchepetkov@ispras.ru> To: Chris Verges Cc: Ilya Shchepetkov , Christian Pellegrin , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, ldv-project@ispras.ru Dynamically allocated sysfs attributes must be initialized using sysfs_attr_init(), otherwise lockdep complains: BUG: key
not in .data! Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Ilya Shchepetkov --- drivers/rtc/rtc-pcf2123.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/rtc/rtc-pcf2123.c b/drivers/rtc/rtc-pcf2123.c index 8361187..13e4df6 100644 --- a/drivers/rtc/rtc-pcf2123.c +++ b/drivers/rtc/rtc-pcf2123.c @@ -43,6 +43,7 @@ #include #include #include +#include #define DRV_VERSION "0.6" @@ -292,6 +293,7 @@ static int __devinit pcf2123_probe(struct spi_device *spi) pdata->rtc = rtc; for (i = 0; i < 16; i++) { + sysfs_attr_init(&pdata->regs[i].attr.attr); sprintf(pdata->regs[i].name, "%1x", i); pdata->regs[i].attr.attr.mode = S_IRUGO | S_IWUSR; pdata->regs[i].attr.attr.name = pdata->regs[i].name;